Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo][example] Updated example functionality #1154

Merged
merged 4 commits into from Mar 2, 2019

Conversation

Projects
None yet
2 participants
@EvanBacon
Copy link
Contributor

EvanBacon commented Mar 1, 2019

Why

Added examples of some common functionality with Expo. Seems valuable for people who want to copy/paste the functionality.

How

  • Updated CustomView
  • Added Touchable to map element
  • Added map linking
  • Added CustomActions
  • Added AccessoryBar
  • Added Footer

Test

You can run it locally or in a snack. Here is a photo of the results:

simulator screen shot - iphone xr - 2019-03-01 at 15 19 49

EvanBacon added some commits Mar 1, 2019

Updated CustomView
* Added touchable to map element
* Added map linking
Added CustomActions
* Added AccessoryBar
* Added Footer
@EvanBacon

This comment has been minimized.

Copy link
Contributor Author

EvanBacon commented Mar 1, 2019

Planning to fix the navigation in another PR. This one is getting kinda heavy. @xcarpentier is it cool if I use react-navigation?

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #1154 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1154   +/-   ##
=======================================
  Coverage   41.03%   41.03%           
=======================================
  Files          21       21           
  Lines         524      524           
  Branches      117      117           
=======================================
  Hits          215      215           
  Misses        233      233           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd54219...1634646. Read the comment docs.

@EvanBacon

This comment has been minimized.

Copy link
Contributor Author

EvanBacon commented Mar 1, 2019

[HOLD] I'm going to merge the media utils

Fixed up utils
* Added permission handling
@EvanBacon

This comment has been minimized.

Copy link
Contributor Author

EvanBacon commented Mar 1, 2019

Ready to go now 😄

@xcarpentier

This comment has been minimized.

Copy link
Collaborator

xcarpentier commented Mar 2, 2019

Planning to fix the navigation in another PR. This one is getting kinda heavy. @xcarpentier is it cool if I use react-navigation?

yes ok

@xcarpentier xcarpentier merged commit 9f30512 into FaridSafi:master Mar 2, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 41.03% remains the same compared to dd54219
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@EvanBacon EvanBacon deleted the expo:@evanbacon/example/general-improvements branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.