Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Bot message implementation (quick replies copy and inspiration) #1211

Open
wants to merge 12 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@xcarpentier
Copy link
Collaborator

commented Apr 30, 2019

Description

Start to provide a solution to add quick replies list component between MessageContainer and Composer.

Image-1 (1)

Limitations

  • In this first implementation, we just provide a single (radio) and multiple (checkbox) selections of option present to the user.

Data definition and example

interface Reply {
  title: string,
  value: string
}

interface QuickReplies {
  type: 'radio' | 'checkbox',
  values: Reply[]
}
{
  _id: 123,
  text: 'This is a quick reply. Do you love Gifted Chat?',
  createdAt: new Date(),
  quickReplies: {
    type: 'radio', // or 'checkbox',
    values: [
      {
        title: '馃構 Yes',
        value: 'yes',
      },
      {
        title: '馃摲 Yes, let me show you with a picture!',
        value: 'yes_picture',
      },
      {
        title: '馃槥 Nope. What?',
        value: 'no',
      },
    ],
  },
}

Inspirations

Pull-requests

Issues

Closes #826

@xcarpentier xcarpentier changed the title Feature/bot message bot message implementation (quick replies copy and inspiration) Apr 30, 2019

@codecov

This comment has been minimized.

Copy link

commented Apr 30, 2019

Codecov Report

鉂楋笍 No coverage uploaded for pull request base (master@e578df2). Click here to learn what that means.
The diff coverage is 12%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1211   +/-   ##
========================================
  Coverage          ?   32.2%           
========================================
  Files             ?      22           
  Lines             ?     590           
  Branches          ?     198           
========================================
  Hits              ?     190           
  Misses            ?     391           
  Partials          ?       9
Impacted Files Coverage 螖
src/GiftedChat.tsx 12.42% <酶> (酶)
src/Bubble.tsx 46.98% <42.85%> (酶)
src/QuickReplies.tsx 6.97% <6.97%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e578df2...d7df967. Read the comment docs.

@xcarpentier xcarpentier changed the title bot message implementation (quick replies copy and inspiration) Bot message implementation (quick replies copy and inspiration) Apr 30, 2019

@xcarpentier xcarpentier requested a review from watadarkstar May 1, 2019

@xcarpentier xcarpentier changed the title Bot message implementation (quick replies copy and inspiration) WIP Bot message implementation (quick replies copy and inspiration) May 1, 2019

@xcarpentier xcarpentier self-assigned this May 1, 2019

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented May 6, 2019

Untitled

@MLK57

This comment has been minimized.

Copy link

commented May 9, 2019

This feature interests me a lot, do you have an idea of 鈥嬧媤hen it will be functional and available ?

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented May 9, 2019

This feature interests me a lot, do you have an idea of 鈥嬧媤hen it will be functional and available ?

ASAP
but you already can use it on npm: 0.9.0-beta.0 (next)

@MLK57

This comment has been minimized.

Copy link

commented May 13, 2019

This feature interests me a lot, do you have an idea of 鈥嬧媤hen it will be functional and available ?

ASAP
but you already can use it on npm: 0.9.0-beta.0 (next)

I have implemented your feature in my project, do you have Skype, Slack or some other way for me to ask you some questions?

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented May 13, 2019

I have implemented your feature in my project, do you have Skype, Slack or some other way for me to ask you some questions?

Yes you can find me here: https://slack.reactnative.gallery/

@xcarpentier xcarpentier force-pushed the feature/bot_message branch 2 times, most recently from 741c829 to 34d1084 May 13, 2019

@xcarpentier xcarpentier force-pushed the feature/bot_message branch from 6639dd8 to 5215680 May 17, 2019

@xcarpentier

This comment has been minimized.

Copy link
Collaborator Author

commented May 17, 2019

@MLK57 can you please test the next: 0.9.0-beta.4 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.