Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flow typedefs #1414

Merged
merged 36 commits into from Sep 24, 2019

Conversation

@amiralies
Copy link
Contributor

commented Sep 23, 2019

Closes #1395

amiralies and others added 6 commits Sep 23, 2019
@xcarpentier

This comment has been minimized.

Copy link
Collaborator

commented Sep 24, 2019

Hi,
Sorry, but can you resolve conflicts?
I will merge it after your resolving.

@amiralies

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

there is no conflict with master branch

@xcarpentier xcarpentier merged commit 49651f7 into FaridSafi:master Sep 24, 2019
@xcarpentier

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2019

Hi @amiralies,
Thanks for this PR!
I try to find a way to automate it because I didn't use flow and I won't update it myself, I think.
To keep it up to date, what do you think if we use this solution: https://github.com/joarwilk/flowgen?
Do you have some time to investigate it?

@amiralies

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

@xcarpentier flowgen doesn't convert all types properly, sepcially external libs such as React native and React.
We can add some readme about updating flow types and say that flow types are not guaranteed to always be updated.

@amiralies

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

@xcarpentier can you release alpha / rc version as next realse on npm so i can test and expermient with flow types?

@xcarpentier

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2019

You can test on this version: 0.10.2-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.