New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example "Slack" UI #649

Merged
merged 3 commits into from Dec 23, 2017

Conversation

Projects
None yet
3 participants
@cooperka
Collaborator

cooperka commented Nov 27, 2017

馃憖 See the screenshots here.

Motivation

  • It's nice to have a full example of overriding the UI
  • Many people want to display usernames
  • Many people want to display all messages on the same side

Changes

  • Added 3 new JS files + screenshots under example-slack-message/
  • Updated the README to point to these examples

Notes

  • The new README points to master for the comparison images, where the screenshots don't exist yet; use the previous commit to see what it would really look like
@phillip055

This comment has been minimized.

Show comment
Hide comment
@phillip055

phillip055 Dec 18, 2017

Really love this

phillip055 commented Dec 18, 2017

Really love this

@xcarpentier

This comment has been minimized.

Show comment
Hide comment
@xcarpentier

xcarpentier Dec 19, 2017

Collaborator

Why not after merging this, add an option to use it in this lib ? Not just as an example.

Collaborator

xcarpentier commented Dec 19, 2017

Why not after merging this, add an option to use it in this lib ? Not just as an example.

@cooperka

This comment has been minimized.

Show comment
Hide comment
@cooperka

cooperka Dec 19, 2017

Collaborator

@xcarpentier that would be great -- feel free to add support for that! I don't have the time right now myself, but I figured I should at least submit this example from my app.

Collaborator

cooperka commented Dec 19, 2017

@xcarpentier that would be great -- feel free to add support for that! I don't have the time right now myself, but I figured I should at least submit this example from my app.

@cooperka

This comment has been minimized.

Show comment
Hide comment
@cooperka

cooperka Dec 19, 2017

Collaborator

Though, maybe we could add it just to the example app, so the example works live? It won't be quite as effective as an example if it's simply turned into a feature.

Collaborator

cooperka commented Dec 19, 2017

Though, maybe we could add it just to the example app, so the example works live? It won't be quite as effective as an example if it's simply turned into a feature.

@xcarpentier

This comment has been minimized.

Show comment
Hide comment
@xcarpentier

xcarpentier Dec 22, 2017

Collaborator

Why not using a expo app for demo like this? It will be more easy to see and test.
I think I will add soon a travis build to deploy example on expo...

Collaborator

xcarpentier commented Dec 22, 2017

Why not using a expo app for demo like this? It will be more easy to see and test.
I think I will add soon a travis build to deploy example on expo...

@cooperka

This comment has been minimized.

Show comment
Hide comment
@cooperka

cooperka Dec 23, 2017

Collaborator

The current example app doesn't use expo, but that would certainly be easy to integrate. Thanks!

Collaborator

cooperka commented Dec 23, 2017

The current example app doesn't use expo, but that would certainly be easy to integrate. Thanks!

@xcarpentier

This comment has been minimized.

Show comment
Hide comment
@xcarpentier

xcarpentier Dec 23, 2017

Collaborator

LGTM 馃憣

Collaborator

xcarpentier commented Dec 23, 2017

LGTM 馃憣

@cooperka cooperka merged commit edf8fff into master Dec 23, 2017

@cooperka cooperka deleted the example-slack-message branch Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment