New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and Fix Slack Example #895

Merged
merged 2 commits into from Jun 12, 2018

Conversation

Projects
None yet
2 participants
@thedmeyer
Contributor

thedmeyer commented Jun 6, 2018

This PR fixes the Slack Example by updating the PropTypes and adding an onSend() function to App.js

@codecov

This comment has been minimized.

codecov bot commented Jun 6, 2018

Codecov Report

Merging #895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   42.73%   42.73%           
=======================================
  Files          20       20           
  Lines         482      482           
  Branches      105      105           
=======================================
  Hits          206      206           
  Misses        208      208           
  Partials       68       68

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87560af...b9acb28. Read the comment docs.

@xcarpentier xcarpentier merged commit dd0a756 into FaridSafi:master Jun 12, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 42.73% remains the same compared to 87560af
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

chilinh added a commit to chilinh/react-native-gifted-chat that referenced this pull request Jun 18, 2018

Merge branch 'r_master'
* r_master:
  Move listViewProps to the end (FaridSafi#882)
  chore(package): update react-test-renderer to version 16.4.0 (FaridSafi#868)
  chore(package): update babel-jest to version 23.0.0 (FaridSafi#869)
  Update and Fix Slack Example (FaridSafi#895)
  Remove prop removeClippedSubviews on Flatlist (FaridSafi#897)
  Update Chatkit readme.md
  Fix typos in TS Types (FaridSafi#877)
  Modified for flatlist (from FaridSafi#629) (FaridSafi#705)
  fix tabs
  ignore example folder
  Add Chatkit asset to README.md
  Add Chatkit banner asset
  chore(package): update react-test-renderer to version 16.3.2 (FaridSafi#829)
  Update README.md (FaridSafi#827)
  add image beacon to readme
  chore(package): update react-test-renderer to version 16.3.1 (FaridSafi#821)

# Conflicts:
#	.eslintignore
#	src/MessageContainer.js

jessestuart added a commit to jessestuart/react-native-gifted-chat that referenced this pull request Aug 9, 2018

Update and Fix Slack Example (FaridSafi#895)
* 👽 Fixing PropTypes

* 🐛 Fix onSend()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment