New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prop to customise to Text style of timestamps #942

Merged
merged 2 commits into from Sep 6, 2018

Conversation

Projects
None yet
3 participants
@gianpaj
Contributor

gianpaj commented Aug 3, 2018

Example:

<GiftedChat
  messages={this.state.messages}
  onSend={this.onSend}
  renderCustomView={CustomView}
  keyboardShouldPersistTaps="never"
  user={{ _id: 1 }}
  renderBubble={props => {
    return (
      <Bubble
        {...props}
        timeTextStyle={{
          right: { color: 'red' }
        }}
      />
    );
  }}
  parsePatterns={this.parsePatterns}
/>

Related to #672

@gianpaj gianpaj changed the title from Add prop to customise to Text style of rendering times to Add prop to customise to Text style of timestamps Aug 3, 2018

@dengue8830

This comment has been minimized.

Show comment
Hide comment
@dengue8830

dengue8830 Sep 6, 2018

why this is not merged?

dengue8830 commented Sep 6, 2018

why this is not merged?

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 6, 2018

Codecov Report

Merging #942 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   42.97%   42.97%           
=======================================
  Files          20       20           
  Lines         498      498           
  Branches      108      108           
=======================================
  Hits          214      214           
  Misses        214      214           
  Partials       70       70
Impacted Files Coverage Δ
src/Time.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052094d...8ffd021. Read the comment docs.

codecov bot commented Sep 6, 2018

Codecov Report

Merging #942 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #942   +/-   ##
=======================================
  Coverage   42.97%   42.97%           
=======================================
  Files          20       20           
  Lines         498      498           
  Branches      108      108           
=======================================
  Hits          214      214           
  Misses        214      214           
  Partials       70       70
Impacted Files Coverage Δ
src/Time.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052094d...8ffd021. Read the comment docs.

@gianpaj

This comment has been minimized.

Show comment
Hide comment
@gianpaj

gianpaj Sep 6, 2018

Contributor

I've fixed the linting and test snapshot issues. CI checks have passed :)

Contributor

gianpaj commented Sep 6, 2018

I've fixed the linting and test snapshot issues. CI checks have passed :)

@xcarpentier xcarpentier merged commit 96f8cf8 into FaridSafi:master Sep 6, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 42.97% remains the same compared to 052094d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xcarpentier

This comment has been minimized.

Show comment
Hide comment
@xcarpentier

xcarpentier Sep 6, 2018

Collaborator

thanks 👍

Collaborator

xcarpentier commented Sep 6, 2018

thanks 👍

@gianpaj gianpaj deleted the gianpaj:patch-1 branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment