Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SensorReadings should allow upload of time created #1363

Closed
gabrielburnworth opened this issue Aug 9, 2019 · 0 comments · Fixed by #1635
Closed

SensorReadings should allow upload of time created #1363

gabrielburnworth opened this issue Aug 9, 2019 · 0 comments · Fixed by #1635
Labels
feature
Projects
FarmBot Project Board

Comments

@gabrielburnworth
Copy link
Contributor

The creation time of a sensor reading is currently set to when the record is added to the API rather than when the reading was taken. Logs are an example of a resource that allows timestamp attachment; this provides a more accurate time value when the record is uploaded some time after it has been created in FarmBot OS.

Relevant code

https://github.com/FarmBot/Farmbot-Web-App/blob/staging/app/mutations/sensor_readings/create.rb

Farmbot-Web-App/app/mutations/logs/create.rb

Line 27 in d18d74f

integer :created_at

@gabrielburnworth gabrielburnworth moved this from Bugs to To do in FarmBot Project Board Nov 20, 2019
@RickCarlino RickCarlino added feature and removed bug labels Nov 21, 2019
RickCarlino added a commit that referenced this issue Dec 20, 2019
@RickCarlino
Add read_at column to sensor_readings table. Closes #1363
077894b
@RickCarlino RickCarlino mentioned this issue Dec 20, 2019
Merged
@RickCarlino RickCarlino moved this from To do to Done, Needs QA in FarmBot Project Board Dec 20, 2019
@gabrielburnworth gabrielburnworth moved this from Done, Needs QA to QA'd, Ready to Deploy in FarmBot Project Board Jan 15, 2020
@roryaronson roryaronson moved this from QA'd, Ready to Deploy to Deployed, Needs Announcement in FarmBot Project Board Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
FarmBot Project Board
Archived in project
FarmBot Project Board
Deployed, Needs Announcement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add read_at column to sensor_readings table. FarmBot/Farmbot-Web-App
2 participants
@RickCarlino @gabrielburnworth