Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Generation #37

Closed
wants to merge 33 commits into from
Closed

Auto Generation #37

wants to merge 33 commits into from

Conversation

jnovack
Copy link
Contributor

@jnovack jnovack commented Mar 19, 2016

Upon installation as a package, this will automatically download the Blizzard/heroprotocol files and hydrate the /lib directory with the javascript versions of the protocols.

This should complete the goal of making this package a true "backend" npm package that can be included in a higher level application. Regeneration of files can be done with an npm install from parent application.

Detailed changes:

  • Remove protocol.js files, require user to generate them.
  • Move src/port.js to postinstall.js
  • Move 'src/protocol.js.template to config/protocol.js.template
  • Update protocol.js.template to include commit version of upstream Blizzard's repo
  • Update protocol.js.template to include generation time.
  • Use src/ as working directory for git downloaded files
  • Move directories and variables to top of postinstall.js
  • Updated newline to \n to be cross-platform compatible
  • Update package.json to auto-generate on install
  • Use fs-extra for mkdirp
  • Corrected smoe tyops
  • Use normalized paths in postinstall.js from __dirname for npm install
  • Use return codes in postinstall.js for npm / deployment
  • Change output of successes and failures for ease of npm-debug.log reading.
  • added myself as contibutor in package.json
  • version bump to v0.3.0

@jnovack
Copy link
Contributor Author

jnovack commented Mar 21, 2016

I think it's done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants