[PULL REQUEST] Improve detection of element with watchForElement

[kiraio-moe]

• I made sure there are no unnecessary changes in the code;
• Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
• Tested on Firefox.

FIX #1269

[github-actions]

Download the artifacts for this pull request:

• FastForward_chromium.zip
• FastForward_firefox.zip

[NotAProton]

Sorry for the delay in reviewing

[kiraio-moe]

Sure, I'll update it on Sunday. Pada Sab, 30 Des 2023 21.53, NotAProton ***@***.***> menulis:

…

***@***.**** requested changes on this pull request. Sorry for the delay in reviewing ------------------------------ In src/helpers/dom.js <#1273 (comment)> : > + * @param {function} f - The function to call. + */ +export function watchForElement (selector, callback) { + return new Promise(resolve => { + const element = document.querySelector(selector) + if (element) { + console.log(`[FastForward] Element found: ${element} | Selector: ${selector}`) + callback(element) + resolve(element) + return + } + + const observer = new MutationObserver(() => { + Array.from(document.querySelectorAll(selector)).forEach(el => { + console.log(`[FastForward] Element found: ${el} | Selector: ${selector}`) + callback(el) + resolve(el) Make it promise-only ⬇️ Suggested change - * @param {function} f - The function to call. - */ -export function watchForElement (selector, callback) { - return new Promise(resolve => { - const element = document.querySelector(selector) - if (element) { - console.log(`[FastForward] Element found: ${element} | Selector: ${selector}`) - callback(element) - resolve(element) - return - } - - const observer = new MutationObserver(() => { - Array.from(document.querySelectorAll(selector)).forEach(el => { - console.log(`[FastForward] Element found: ${el} | Selector: ${selector}`) - callback(el) - resolve(el) + * @returns {Promise<any>} A promise that resolves with the element. + */ +export function watchForElement (selector) { + return new Promise(resolve => { + const element = document.querySelector(selector) + if (element) { + console.log(`[FastForward] Element found: ${element} | Selector: ${selector}`) + resolve(element) + return + } + + const observer = new MutationObserver(() => { + Array.from(document.querySelectorAll(selector)).forEach(el => { + console.log(`[FastForward] Element found: ${el} | Selector: ${selector}`) + resolve(el) — Reply to this email directly, view it on GitHub <#1273 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AN4W4LSETT4ITCUYEUAB4ETYMATGRAVCNFSM6AAAAABAKIAB5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJZGU3DIMJTGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>