Permalink
Browse files

WAIT_TIME=50 to allow interrupts without breaking matrix output. (#596)

* WAIT_TIME=50 to allow interrupts without breaking matrix output.

WAIT_TIME set to 5 was too short and FastLED aborted frames too early
and restarted them incorrectly.
(as explained by Daniel Garcia in
https://plus.google.com/communities/109127054924227823508 )

Tested on ESP8266 with 768 LED matrix in both serialized output
and 3x 256 output.

* Update clockless_block_esp8266.h

* Update clockless_esp8266.h
  • Loading branch information...
marcmerlin authored and focalintent committed Jun 23, 2018
1 parent 385a56f commit dcbf39933f51a2a0e4dfa0a2b3af4f50040df5c9
Showing with 2 additions and 2 deletions.
  1. +1 −1 platforms/esp/8266/clockless_block_esp8266.h
  2. +1 −1 platforms/esp/8266/clockless_esp8266.h
@@ -17,7 +17,7 @@ extern uint32_t _frame_cnt;
extern uint32_t _retry_cnt;
#endif
template <uint8_t LANES, int FIRST_PIN, int T1, int T2, int T3, EOrder RGB_ORDER = GRB, int XTRA0 = 0, bool FLIP = false, int WAIT_TIME = 5>
template <uint8_t LANES, int FIRST_PIN, int T1, int T2, int T3, EOrder RGB_ORDER = GRB, int XTRA0 = 0, bool FLIP = false, int WAIT_TIME = 50>
class InlineBlockClocklessController : public CPixelLEDController<RGB_ORDER, LANES, PORT_MASK> {
typedef typename FastPin<FIRST_PIN>::port_ptr_t data_ptr_t;
typedef typename FastPin<FIRST_PIN>::port_t data_t;
@@ -16,7 +16,7 @@ __attribute__ ((always_inline)) inline static uint32_t __clock_cycles() {
#define FASTLED_HAS_CLOCKLESS 1
template <int DATA_PIN, int T1, int T2, int T3, EOrder RGB_ORDER = RGB, int XTRA0 = 0, bool FLIP = false, int WAIT_TIME = 5>
template <int DATA_PIN, int T1, int T2, int T3, EOrder RGB_ORDER = RGB, int XTRA0 = 0, bool FLIP = false, int WAIT_TIME = 50>
class ClocklessController : public CPixelLEDController<RGB_ORDER> {
typedef typename FastPin<DATA_PIN>::port_ptr_t data_ptr_t;
typedef typename FastPin<DATA_PIN>::port_t data_t;

0 comments on commit dcbf399

Please sign in to comment.