New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Const qualifier not present on non-mutating functions #332

Closed
kavika13 opened this Issue Aug 2, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@kavika13

kavika13 commented Aug 2, 2016

I don't know how deep this issue is (I suspect it is missing from several places in the library, not just a single object).

I tried calling lerp8 on a const CRGB object just now, and it wouldn't compile.

If you change CRGB::lerp8 to this signature, the problem should clear up:

inline CRGB lerp8( CRGB & other, fract8 frac) const // <-- Notice `const` here
{
    // ...
@focalintent

This comment has been minimized.

Show comment
Hide comment
@focalintent

focalintent Aug 16, 2017

Member

Pull request merged, closing this issue.

Member

focalintent commented Aug 16, 2017

Pull request merged, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment