New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FASTLED_ALLOW_INTERRUPTS for Teensy + typo? #488

Closed
NicoHood opened this Issue Aug 26, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@NicoHood
Contributor

NicoHood commented Aug 26, 2017

// Default to disallowing interrupts (may want to gate this on teensy2 vs. other arm platforms, since the
// teensy2 has a good, fast millis interrupt implementation)
#ifndef FASTLED_ALLOW_INTERRUPTS
#define FASTLED_ALLOW_INTERRUPTS 0
#endif

  1. Does this mean if you are using the teensy2 core, then interrupts can be enabled, as the code is better? If yes, why dont you do that? Or does this statement mean, that its untested but will more likely work on a teensy2?

  2. teensy2 vs. other arm platforms is possibly a typo and you mean avr?

@focalintent

This comment has been minimized.

Show comment
Hide comment
@focalintent

focalintent Jun 23, 2018

Member
  1. No - it was a note to myself that it might have been possible to make it work in the future.
  2. it is a typo

but neither of the above matter, because it turns out that even on the teensy 2 allowing interrupts is a bad idea and I yanked all the relevant code out of the avr asm, so even if you set FASTLED_ALLOW_INTERRUPTS to 1 on an avr platform it would have no effect.

Member

focalintent commented Jun 23, 2018

  1. No - it was a note to myself that it might have been possible to make it work in the future.
  2. it is a typo

but neither of the above matter, because it turns out that even on the teensy 2 allowing interrupts is a bad idea and I yanked all the relevant code out of the avr asm, so even if you set FASTLED_ALLOW_INTERRUPTS to 1 on an avr platform it would have no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment