New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 Reset Duration #615

Open
Kyklas opened this Issue Jun 17, 2018 · 2 comments

Comments

Projects
None yet
4 participants
@Kyklas

Kyklas commented Jun 17, 2018

Could someone double check if the following code can be called ?
https://github.com/FastLED/FastLED/blob/master/platforms/esp/32/clockless_esp32.h#L491
if (done_strip) RMTMEM.chan[mRMT_channel].data32[mCurPulse-1].duration1 = RMT_RESET_DURATION;
I think done_strip in the while loop is always false, else the loop is exited at the start in the "if not has 1" condition. https://github.com/FastLED/FastLED/blob/master/platforms/esp/32/clockless_esp32.h#L455

Thanks

@focalintent

This comment has been minimized.

Member

focalintent commented Jun 17, 2018

Mark - can you ping @samguyer about this one?

@samguyer

This comment has been minimized.

Contributor

samguyer commented Jun 17, 2018

Yeah, that looks like a mistake. The way it is supposed to work is that the last real pulse out should have a duration that makes the strip latch. It's usually not a problem, since most sketches have a delay between frames, but I'll take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment