ESP32 Reset Duration

[Kyklas]

Could someone double check if the following code can be called ?
https://github.com/FastLED/FastLED/blob/master/platforms/esp/32/clockless_esp32.h#L491
if (done_strip) RMTMEM.chan[mRMT_channel].data32[mCurPulse-1].duration1 = RMT_RESET_DURATION;
I think done_strip in the while loop is always false, else the loop is exited at the start in the "if not has 1" condition. https://github.com/FastLED/FastLED/blob/master/platforms/esp/32/clockless_esp32.h#L455

Thanks

[focalintent]

Mark - can you ping @samguyer about this one?

[samguyer]

Yeah, that looks like a mistake. The way it is supposed to work is that the last real pulse out should have a duration that makes the strip latch. It's usually not a problem, since most sketches have a delay between frames, but I'll take a look at it.

[focalintent]

This code has changed a lot since.