New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRGB::maximizeBrightness() causes Divide By Zero error with color Black #704

Open
K1ngjulien opened this Issue Dec 22, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@K1ngjulien
Copy link

K1ngjulien commented Dec 22, 2018

The function does not check if all of the color channels are zero and therefor tries to divide by zero when maximizing the brightness.

inline void maximizeBrightness( uint8_t limit = 255 ) {

@K1ngjulien K1ngjulien referenced a pull request that will close this issue Dec 22, 2018

Open

Fixed Divide by 0 in CRGB::maximizeBrightness #705

@kriegsman

This comment has been minimized.

Copy link
Contributor

kriegsman commented Dec 22, 2018

Thank you; I’ll take a look, should be quick. Much appreciated.

@kriegsman kriegsman self-assigned this Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment