Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitswap -- portability issues or intentional? #777

Open
henrygab opened this issue Apr 21, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@henrygab
Copy link

commented Apr 21, 2019

See henrygab@9dfd95e.

Basically, two questions:

  1. Was the definition of the structure just8bits to be four bytes in size intentional?
    Is there a negative to declaring the structure to be only a single byte?
    See, for example, lines 16-28.

  2. Was the use of unsigned int instead of uint32_t within the transpose 8x1 functions intentional?
    I think this one must be a bug, as it's valid for unsigned int to be less than 32 bits, and there are no static assertions to ensure it uses at least 32 bits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.