Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHSVPalette256 seems like it shouldn't be initialized with a TProgmemRGBPalette16 #807

Open
ssilverman opened this issue May 26, 2019 · 1 comment

Comments

Projects
None yet
1 participant
@ssilverman
Copy link

commented May 26, 2019

CHSVPalette16 p16(rhs);

Is it my imagination or is there no valid CHSVPalette16 constructor that uses a TProgmemRGBPalette16? CHSVPalette256 uses this in one of its constructors and in one of its operator= definitions. Should this instead be TProgmemHSVPalette16?

@ssilverman

This comment has been minimized.

Copy link
Author

commented May 27, 2019

I'll add: I'm aware that this may be automatically converting types, but I'm not convinced the results will be as expected. If TProgmemRGBPalette16 is auto-converted to TProgmemHSVPalette16 then the uint32_t values won't be correct. Am I reading this right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.