Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are inconsistent in terms of color order for WS2812(B) and NeoPixel #878

Open
MartyMacGyver opened this issue Sep 3, 2019 · 0 comments · May be fixed by #879

Comments

@MartyMacGyver
Copy link

commented Sep 3, 2019

The color signalling order for NeoPixels (the WS2812 variety), WS2812, WS2812B, WS2852, and SK6812 LEDs are all GRB, not RGB. However, the examples are unclear on this matter.

For instance, Blink.ino shows many pixel types and their configurations, but of the types above only the default NeoPixel one will work right "out of the box" - the WS2812, WS2812B, WS2852, and SK6812 (where present) will not, as they specify the RGB color order, not their normal GRB order.

It would be good to have a small comment by the NeoPixel line noting its implicit default to GRB signalling, and the WS2812/WS2812B/WS2852/SK6812 ones (where present) should actually specify GRB rather than RGB.

I've seen notes suggesting inconsistencies within these groups, but I suspect this is down to users mixing up APA102 / SK6822 with WS2812 variants above (APA102 seems to have several color orders - but I've yet to see a properly marked WS2812 vary from GRB - if one does, it's not the norm).

Making the examples more explicit about NeoPixel / WS2812 / WS2812B / WS2852 / SK6812 being typically GRB will help reduce user confusion.

MartyMacGyver added a commit to MartyMacGyver/FastLED that referenced this issue Sep 3, 2019

@kriegsman kriegsman self-assigned this Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.