Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary macro `NO_PIN` causing name collisions #893

Open
tttapa opened this issue Sep 23, 2019 · 2 comments

Comments

@tttapa
Copy link

commented Sep 23, 2019

The following line defines a NO_PIN macro that doesn't seem to be used anywhere, but it does cause name collisions when using other libraries that use NO_PIN as an identifier for a constant, for example.

#define NO_PIN 255

Could this be changed from a macro to a constant?

@tttapa tttapa changed the title Unnecessary macro Unnecessary macro `NO_PIN` causing name collisions Sep 23, 2019
@kriegsman

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Thanks, I bet we can change it. Appreciate the ticket here.

@kriegsman kriegsman self-assigned this Sep 23, 2019
@tttapa

This comment has been minimized.

Copy link
Author

commented Sep 23, 2019

Great, thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.