Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking NRF52 pending PRs #948

Open
henrygab opened this issue Jan 4, 2020 · 2 comments
Open

Tracking NRF52 pending PRs #948

henrygab opened this issue Jan 4, 2020 · 2 comments

Comments

@henrygab
Copy link
Contributor

@henrygab henrygab commented Jan 4, 2020

Until the depot resumes taking PRs, I'm integrating those needed for the nrf52 series of chips into my nrf52 fork, as a way to help simplify getting people up and running during this transitional time.

Currently integrated PRs:

  • #946 Missing underscores in _FL_DEFPIN causing compilation fail (regression from #866) (Issue #938)
  • #900 Fix compilation fail for NRF52832 (and other single-port NRF52 chips) (Issue #919)

Feel free to reference additional NRF52 related PRs within this issue, that you'd like to see integrated in the interim.

@lmh91

This comment has been minimized.

Copy link

@lmh91 lmh91 commented Jan 7, 2020

I think #917 should be added here?

I also have a Arduino Nano 33 BLE (nRF52840) and can't compile FastLED with the same error as in this issue.

@henrygab

This comment has been minimized.

Copy link
Contributor Author

@henrygab henrygab commented Jan 8, 2020

#917 is a different issue … that's for support of a brand new board. I'll follow-up on #917.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.