New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastLED version #487

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
2 participants
@NicoHood
Contributor

NicoHood commented Aug 25, 2017

No description provided.

@focalintent

This comment has been minimized.

Show comment
Hide comment
@focalintent

focalintent Aug 25, 2017

Member

Is anyone even using FASTLED_VERSION? (Other than demoreel, that is)

Member

focalintent commented Aug 25, 2017

Is anyone even using FASTLED_VERSION? (Other than demoreel, that is)

@focalintent focalintent merged commit 8aed76e into FastLED:master Aug 25, 2017

@NicoHood

This comment has been minimized.

Show comment
Hide comment
@NicoHood

NicoHood Aug 25, 2017

Contributor

Possibly yes. It really makes sense to check for a minimum required version number if you depend on a special new fix.

BTW: Are you able to cherry pick my commits from here, except the first or should I create a separate PR for that?

I got the whole code compiling fine now with my makefile. However I still got no hardware to test. I will publish the stuff soon, so maybe someone else can test it for me.

I also made a makefile for the FastPin header subset, so you can use fast pin access. For further versions you might want to outsource this library maybe, I find it extremely useful.

Contributor

NicoHood commented Aug 25, 2017

Possibly yes. It really makes sense to check for a minimum required version number if you depend on a special new fix.

BTW: Are you able to cherry pick my commits from here, except the first or should I create a separate PR for that?

I got the whole code compiling fine now with my makefile. However I still got no hardware to test. I will publish the stuff soon, so maybe someone else can test it for me.

I also made a makefile for the FastPin header subset, so you can use fast pin access. For further versions you might want to outsource this library maybe, I find it extremely useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment