New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in fastpin_esp32 header #533

Merged
merged 1 commit into from Nov 30, 2017

Conversation

Projects
None yet
2 participants
@tullo-x86
Contributor

tullo-x86 commented Nov 30, 2017

Bottom of file should expand the FASTLED_NAMESPACE_END macro, not #define it.

This is the sort of bug that could go undetected for years until you reorder your #includes one day.

Fix typo in fastpin_esp32 header
Bottom of file should expand FASTLED_NAMESPACE_END macro, not #define it
@focalintent

This comment has been minimized.

Show comment
Hide comment
@focalintent

focalintent Nov 30, 2017

Member

Namespaces are only used on the particle boards - so it’s “safe” here for now - but good catch!

Member

focalintent commented Nov 30, 2017

Namespaces are only used on the particle boards - so it’s “safe” here for now - but good catch!

@focalintent focalintent merged commit c1ab8fa into FastLED:master Nov 30, 2017

@tullo-x86

This comment has been minimized.

Show comment
Hide comment
@tullo-x86

tullo-x86 Dec 1, 2017

Contributor

Maybe one of these days I'll contribute more than a fix for a rogue #warning or an unused macro redefinition 😅

Contributor

tullo-x86 commented Dec 1, 2017

Maybe one of these days I'll contribute more than a fix for a rogue #warning or an unused macro redefinition 😅

@tullo-x86 tullo-x86 deleted the tullo-x86:fix-esp32-typo branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment