Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent include syntax/formatting #571

Merged
merged 1 commit into from Apr 18, 2018

Conversation

Projects
None yet
3 participants
@per1234
Copy link
Contributor

per1234 commented Feb 17, 2018

  • Angle brackets for external includes
  • Space after #include directive
Use consistent include syntax
- Angle brackets for external includes
- Space after #include directive
@kriegsman

This comment has been minimized.

Copy link
Contributor

kriegsman commented Mar 24, 2018

Thanks for the cleanup PR!
The only item I have a question about in this PR is the change from "./dmx" to "dmx.h". I wonder if the original included the "./" for a reason, e.g. some other dmx.h being accidentally found in a search path somewhere.
Any thoughts?

@per1234

This comment has been minimized.

Copy link
Contributor Author

per1234 commented Mar 24, 2018

I puzzled over that one too. My understanding is that the #include "dmx.h" syntax should always search the current folder first before the rest of the include search paths so I can't see how that would be necessary.

https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html

#include "file"
This variant is used for header files of your own program. It searches for a file named file first in the directory containing the current file

I'm happy to remove that part of the PR if you like.

@focalintent focalintent merged commit 6fd2366 into FastLED:master Apr 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.