From d38dcec020a8d77ebf2caac19b3eca3949124201 Mon Sep 17 00:00:00 2001 From: Zach Vorhies Date: Sat, 5 Sep 2026 16:27:27 -0700 Subject: [PATCH] fix(test): follow the soldr pin #1416 moved to 0.9.12 `native_release_workflow_uses_current_cross_toolchains` asserts the exact soldr version `template_native_build.yml` pins. #1416 (e4a871a9) moved that pin 0.9.6 -> 0.9.12 for the pkg-config sysroot fix, but left the test's expected value at 0.9.6, so `Check` has been red on main ever since: assertion `left == right` failed: the setup-soldr step needs soldr >= 0.9.5 for catalogue-v2 Apple SDK assets left: Some("0.9.12") right: Some("0.9.6") That blocks every open PR, not just the branch that noticed it. Follow the pin, and extend the message to name the second floor as well -- it previously cited only the 0.9.5 catalogue-v2 requirement, which no longer explains why the pin sits where it does. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01MLhWkMfzLjrnLTDMBE6Fj9 --- crates/fbuild-python/tests/pyo3_policy.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/fbuild-python/tests/pyo3_policy.rs b/crates/fbuild-python/tests/pyo3_policy.rs index f2977848..b8f0ef25 100644 --- a/crates/fbuild-python/tests/pyo3_policy.rs +++ b/crates/fbuild-python/tests/pyo3_policy.rs @@ -216,8 +216,9 @@ fn native_release_workflow_uses_current_cross_toolchains() { assert_eq!( yaml_step_mapping_value(&workflow_lines, "Setup soldr", &["with", "version"]), - Some("0.9.6"), - "the setup-soldr step needs soldr >= 0.9.5 for catalogue-v2 Apple SDK assets" + Some("0.9.12"), + "the setup-soldr step needs soldr >= 0.9.5 for catalogue-v2 Apple SDK \ + assets and >= 0.9.12 for the pkg-config sysroot fix" ); assert_eq!( yaml_mapping_value(