New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1 #6

Merged
merged 2 commits into from Nov 15, 2012

Conversation

Projects
None yet
2 participants
@jonnyzzz
Contributor

jonnyzzz commented Nov 7, 2012

Looks like I managed to implement the fix for issue 1.
Please take a look into my patch

jonnyzzz added some commits Nov 6, 2012

fix issue 1. Support true generics POJO.
The trick for generic class to generate abstract implementation to make JVM resolve all type variables for us. Next call older code for non-generic class.
@cowtowncoder

This comment has been minimized.

Show comment
Hide comment
@cowtowncoder

cowtowncoder Nov 7, 2012

Member

Wow. This would be EXCELLENT news. I will need to go through the code, but from quick look I think this looks good.
I would love to solve this issue.

Member

cowtowncoder commented Nov 7, 2012

Wow. This would be EXCELLENT news. I will need to go through the code, but from quick look I think this looks good.
I would love to solve this issue.

@cowtowncoder

This comment has been minimized.

Show comment
Hide comment
@cowtowncoder

cowtowncoder Nov 15, 2012

Member

Apologies for the delay; 2.1.1 release got in the way (should have done before that but...).
Still planning to integrate this soon.

Member

cowtowncoder commented Nov 15, 2012

Apologies for the delay; 2.1.1 release got in the way (should have done before that but...).
Still planning to integrate this soon.

cowtowncoder added a commit that referenced this pull request Nov 15, 2012

@cowtowncoder cowtowncoder merged commit 3f35d0c into FasterXML:master Nov 15, 2012

@cowtowncoder

This comment has been minimized.

Show comment
Hide comment
@cowtowncoder

cowtowncoder Nov 15, 2012

Member

Awesome -- I fixed the two unit tests to do proper type checks.

Member

cowtowncoder commented Nov 15, 2012

Awesome -- I fixed the two unit tests to do proper type checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment