Simplify handling of LocalDate value with invalid trailing time-portion
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
commented
Mar 26, 2021
| @@ -155,7 +155,8 @@ protected LocalDate _fromString(JsonParser p, DeserializationContext ctxt, | |||
| // JavaScript by default includes time in JSON serialized Dates (UTC/ISO instant format). | |||
| if (string.length() > 10 && string.charAt(10) == 'T') { | |||
| if (string.endsWith("Z")) { | |||
| return LocalDateTime.ofInstant(Instant.parse(string), ZoneOffset.UTC).toLocalDate(); | |||
| return LocalDate.parse(string.substring(0, string.length() - 1), | |||
| DateTimeFormatter.ISO_LOCAL_DATE_TIME); | |||
There was a problem hiding this comment.
Seems to me that there is no need to go back and forth to zoned instant when simply trying to retain local value.
Tests all pass as well.
…n passing section)
|
@kupci Just noticed this when looking at LocalDate/LocalDateTime deserialization; wanted to sanity check my thinking here. |
kupci
approved these changes
Mar 26, 2021
|
I copied that from I actually should file an issue for that change, and simplification can just be part of implementation for that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title: test change just cleaning up, but for
LocalDate, avoid unnecessary handling of timezone.