Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Fix some Korean translations #1245

Merged
merged 7 commits into from
Jul 24, 2022
Merged

Conversation

item4
Copy link
Contributor

@item4 item4 commented Jul 12, 2022

No description provided.

@reconman
Copy link
Collaborator

I've added more translatable strings in ea8ebf4#diff-2d207ac16b141c7910606683e804e844a24ef211c6210e4f1842673f396495e8

And I make empty lines for match each line by line numbers. By new
empty new line, we can find and check what item is missing againist
English sources.
@item4
Copy link
Contributor Author

item4 commented Jul 18, 2022

@reconman I checked and add more translated strings.

@reconman reconman merged commit 7a3004a into Fate-Grand-Automata:master Jul 24, 2022
@reconman
Copy link
Collaborator

You wrote something in the commit message about matching empty lines. Do you know about the Translations Editor in Android Studio? See #1213 (comment)

@item4 item4 deleted the ko_KR branch July 24, 2022 17:09
@item4
Copy link
Contributor Author

item4 commented Jul 24, 2022

oh, I use neovim only this time. I will check that comment next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants