Support for KR server updates #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
item4
changed the title
reconman
requested changes
Aug 25, 2022
scripts/src/main/java/com/mathewsachin/fategrandautomata/scripts/modules/Caster.kt
Outdated
Show resolved
Hide resolved
scripts/src/main/java/com/mathewsachin/fategrandautomata/scripts/modules/Caster.kt
Outdated
Show resolved
Hide resolved
|
Can you please test the version with my commit? |
|
@reconman Good! It works fine. I was removed 2 seconds waiting for too long wait after skill effect but can not reproduce on your change revision |
reconman
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since update KR server 2022-08-25, KR version has some new features from Jp upstream.
So I add Kr server in append skill enum and add additional click at
Caster.kton waiting skill animation completionFix #1042
Fix #1322