Skip to content

Support for KR server updates#1319

Merged
reconman merged 5 commits into
Fate-Grand-Automata:masterfrom
item4:KR-skip-skill
Aug 26, 2022
Merged

Support for KR server updates#1319
reconman merged 5 commits into
Fate-Grand-Automata:masterfrom
item4:KR-skip-skill

Conversation

@item4

@item4 item4 commented Aug 25, 2022

Copy link
Copy Markdown
Contributor

Since update KR server 2022-08-25, KR version has some new features from Jp upstream.

  1. Can use Append Skill
  2. Can skip skill effect animation by touching screen anywhere. (Introduce Video: https://youtu.be/iJ1g_QIWLXY?t=5802)

So I add Kr server in append skill enum and add additional click at Caster.kt on waiting skill animation completion


Fix #1042
Fix #1322

@item4 item4 changed the title Support Skip skill effect animation feature for KR server Support for KR server updates Aug 25, 2022
@reconman

Copy link
Copy Markdown
Collaborator

Can you please test the version with my commit?

@item4

item4 commented Aug 26, 2022

Copy link
Copy Markdown
Contributor Author

@reconman Good! It works fine. I was removed 2 seconds waiting for too long wait after skill effect but can not reproduce on your change revision

@item4 item4 requested a review from reconman August 26, 2022 01:19
@reconman reconman merged commit f834f19 into Fate-Grand-Automata:master Aug 26, 2022
@item4 item4 deleted the KR-skip-skill branch August 26, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FGA does not work after Append Skill introduction in KR Quick double tap on skill activation (JP)

2 participants