-
-
Notifications
You must be signed in to change notification settings - Fork 284
Fix inventory full checker #1376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Sometimes, detector guess wrong some white and black things as inven_full in battle and fp summon 2. I tried to increase similarity rate but it's fail. 3. I find inventory was full, there must be selling button with current detect target(enhancement button) 4. I fix to use this button
scripts/src/main/java/com/mathewsachin/fategrandautomata/scripts/entrypoints/AutoBattle.kt
Outdated
Show resolved
Hide resolved
scripts/src/main/java/com/mathewsachin/fategrandautomata/scripts/locations/Locations.kt
Outdated
Show resolved
Hide resolved
@reconman It was merged on my branch and pr already by your changes. I will test it and attach video. |
Running on 2ce97bfrecord.mp4 |
What I want to detect for catch inventory was fullButCan not catch it. So I decrease similarity. It was work, but has side-effects Expected screens, but can not dectect nowWrong detection on low similarityWhat really I want to detectCase 1. detect text correctlyCase 2. detect two buttonsProblems what I can not solve
|
Please test the latest build again. |
@reconman Wow. Good It works! I did not know pattern image must capture in 720p. but how can i take 720p correctly? resize after screenshot? or other method here? |
Yes, you need a photo editor like Adobe Photoshop or the free online Photopea to scale your image down. |
I was make PR changing FP gacha, but I feel something strange and I make new PR.
inv_full.png
for Kr server because FGA can not detectReinforce
button.This PR tested on Kr server and it's fine.