Fix inventory full checker#1376
Merged
Merged
Conversation
1. Sometimes, detector guess wrong some white and black things as inven_full in battle and fp summon 2. I tried to increase similarity rate but it's fail. 3. I find inventory was full, there must be selling button with current detect target(enhancement button) 4. I fix to use this button
reconman
reviewed
Sep 10, 2022
Contributor
Author
|
@reconman It was merged on my branch and pr already by your changes. I will test it and attach video. |
Contributor
Author
Running on 2ce97bfrecord.mp4 |
Contributor
Author
What I want to detect for catch inventory was fullButCan not catch it. So I decrease similarity. It was work, but has side-effects Expected screens, but can not dectect nowWrong detection on low similarityWhat really I want to detectCase 1. detect text correctlyCase 2. detect two buttonsProblems what I can not solve
|
Collaborator
Collaborator
|
Please test the latest build again. |
Contributor
Author
|
@reconman Wow. Good It works! I did not know pattern image must capture in 720p. but how can i take 720p correctly? resize after screenshot? or other method here? |
Collaborator
|
Yes, you need a photo editor like Adobe Photoshop or the free online Photopea to scale your image down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.










I was make PR changing FP gacha, but I feel something strange and I make new PR.
inv_full.pngfor Kr server because FGA can not detectReinforcebutton.This PR tested on Kr server and it's fine.