Support New UI of KR server

[item4]

I can not check it is working correctly because I am not app developer.

For testing, merge and build on GitHub Actions

---

fix #786

[reconman]

Can you test the build yourself? https://github.com/Fate-Grand-Automata/FGA/suites/3328601476/artifacts/78016401

[kbg0104]

@reconman Based on Galaxy 21, there is still a problem that the location of the click on the battle screen and the friend selection is not in sync.

[kbg0104]

@reconman

[item4]

touch 6th servent slot instead of quest start

I guess it is some wrong value of here:

FGA/scripts/src/main/java/com/mathewsachin/fategrandautomata/scripts/modules/Game.kt

Lines 104 to 105 in 732a831

	(if (isWide)
	Location(-350, -160)

[item4]

@kbg0104 canary 말고 app.zip 파일 받아보세요

[item4]

@reconman battle is fine. but first quest start is werid

[kbg0104]

@item4 위 스크린샷이 그걸로 테스트 해본겁니다. 디스플레이의 비율에 영향을 많이 받는것같군요. The above screenshot was tested using app.zip. It seems that the ratio of the display is greatly affected.

[item4]

@kbg0104 서버 한국 선택 하셨나요? 한국 선택하면 셀렉창에서 디버그가 저렇게 안 떠서요

[kbg0104]

@item4 네, 혹시나 해서 한국서버로 바꾸고 해봐도 똑같네요. 삭제, 재설치 이후에도 똑같이 나왔습니다.

[item4]

Finally I do run battle with this PR, and it is the settings:

1. Select KR server
2. Disable(uncheck) Ignore notch flag
3. Go to Android Preference > Display > Fullscreen Apps, and turn off FGO. (Do not use as fullscreen)
4. Turn off FGO completely.
5. Stop service and Turn off FGA completely.
6. Play it.

Note: Do not try take screen recording in using FGA. It break FGA sanity.

[MathewSachin]

@kgb you have black bars on both sides of the screen similar to #784. This build would only work if FGO covers the whole screen including the notch. I think you need to make FGO a full-screen app.

touch 6th servent slot instead of quest start
I guess it is some wrong value of here:

@item4 Starting from the Party selection screen was never supported. It's clicking wrong because it can't detect which screen it is.

1. Select KR server

Does Auto detect not detect KR server now?

2. Disable(uncheck) Ignore notch flag

This has no effect. IsNewUI implies ignore notch.

FGA/app/src/main/java/com/mathewsachin/fategrandautomata/util/CutoutManager.kt

Lines 74 to 75 in 732a831

	private fun shouldIgnoreNotch() =
	prefs.isNewUI || prefs.ignoreNotchCalculation

3. Go to Android Preference > Display > Fullscreen Apps, and turn off FGO. (Do not use as fullscreen)

I would like to see the script running after turning this OFF. I believe this needs to be ON.

Note: Do not try take screen recording in using FGA. It break FGA sanity.

Which is why there's an inbuilt recording feature in the app. Check More options/Advanced.

[item4]

I would like to see the script running after turning this OFF. I believe this needs to be ON.

Yes I agree. Seperated usage guide make user painful. But i am not well knowing this environment such as android, kotlin and so on, and I can not run sainly with fullscreen flag. Just I guess android fullscreen settings make difference of screen resolution and dimension.

Does Auto detect not detect KR server now?

Need to do test. but I have no AP now. I will try that after morning.

[MathewSachin]

Yes I agree. Seperated usage guide make user painful. But i am not well knowing this environment such as android, kotlin and so on, and I can not run sainly with fullscreen flag. Just I guess android fullscreen settings make difference of screen resolution and dimension

I think there's a misunderstanding.
I meant to ask for a video showing the script running. You can record video from within FGA by turning it ON from More options/Advanced.

[MathewSachin]

@sleeping-player, @ScathachSkadi
Can you guys check if this build works: https://github.com/Fate-Grand-Automata/FGA/suites/3328601476/artifacts/78016401

[sleeping-player]

Ah, since I haven't done KR since the beginning of this year, it's difficult to test. I'm sorry for that.

[kbg0104]

@MathewSachin
In Galaxy S21, there was only the same result as the screenshot above.
#787 (comment)
I think it's probably a bug on this issue. #784 (comment) I think I'll have to go through a personal process.

Since then, it has been confirmed that the game works normally by running it on the full screen.

All functions worked normally in Galaxy Note 9.
There was no problem choosing friends, dungeons, or consecutive dungeons that had previously been a problem.

[reconman]

@kbg0104 Please do this and share the video:

[kbg0104]

@reconman
Everything is working normally.
The video was modified randomly due to its capacity. (Resizing and Cutting)
I used Galaxy S21.

record.mp4

record.1.mp4

[MathewSachin]

@Yoshinyong Can you check the apk from this page: https://github.com/Fate-Grand-Automata/FGA/suites/3328601476/artifacts/78016401
Also, reset the stage counter similarity value for this build. Don't use 100% for this one.

[item4]

@MathewSachin I tested auto detect server and work fine

[item4]

I take video record but it is too huge to upload at GitHub.

There is no problem. But sometime area detect debug box placed wrong place.

(Check @kbg0104 's first upload video)

[ScathachSkadi]

@MathewSachin Sorry I am late. I tested the build by making the app full screen and it works perfectly. My device is S20+.