Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support New UI of KR server #787

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Support New UI of KR server #787

merged 2 commits into from
Jul 27, 2021

Conversation

item4
Copy link
Contributor

@item4 item4 commented Jul 26, 2021

I can not check it is working correctly because I am not app developer.

For testing, merge and build on GitHub Actions


fix #786

@reconman
Copy link
Collaborator

@kbg0104
Copy link

kbg0104 commented Jul 26, 2021

@reconman Based on Galaxy 21, there is still a problem that the location of the click on the battle screen and the friend selection is not in sync.

@kbg0104
Copy link

kbg0104 commented Jul 26, 2021

@reconman
3 mp4_20210726_184708 031
4 mp4_20210726_184856 982
4 mp4_20210726_184905 950

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

touch 6th servent slot instead of quest start

I guess it is some wrong value of here:

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

@kbg0104 canary 말고 app.zip 파일 받아보세요

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

@reconman battle is fine. but first quest start is werid

@kbg0104
Copy link

kbg0104 commented Jul 26, 2021

@item4 위 스크린샷이 그걸로 테스트 해본겁니다. 디스플레이의 비율에 영향을 많이 받는것같군요. The above screenshot was tested using app.zip. It seems that the ratio of the display is greatly affected.

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

@kbg0104 서버 한국 선택 하셨나요? 한국 선택하면 셀렉창에서 디버그가 저렇게 안 떠서요

@kbg0104
Copy link

kbg0104 commented Jul 26, 2021

@item4 네, 혹시나 해서 한국서버로 바꾸고 해봐도 똑같네요. 삭제, 재설치 이후에도 똑같이 나왔습니다.

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

Finally I do run battle with this PR, and it is the settings:

  1. Select KR server
  2. Disable(uncheck) Ignore notch flag
  3. Go to Android Preference > Display > Fullscreen Apps, and turn off FGO. (Do not use as fullscreen)
  4. Turn off FGO completely.
  5. Stop service and Turn off FGA completely.
  6. Play it.

Note: Do not try take screen recording in using FGA. It break FGA sanity.

@MathewSachin
Copy link
Collaborator

@kgb you have black bars on both sides of the screen similar to #784. This build would only work if FGO covers the whole screen including the notch. I think you need to make FGO a full-screen app.

touch 6th servent slot instead of quest start
I guess it is some wrong value of here:

@item4 Starting from the Party selection screen was never supported. It's clicking wrong because it can't detect which screen it is.

  1. Select KR server

Does Auto detect not detect KR server now?

  1. Disable(uncheck) Ignore notch flag

This has no effect. IsNewUI implies ignore notch.

private fun shouldIgnoreNotch() =
prefs.isNewUI || prefs.ignoreNotchCalculation

  1. Go to Android Preference > Display > Fullscreen Apps, and turn off FGO. (Do not use as fullscreen)

I would like to see the script running after turning this OFF. I believe this needs to be ON.

Note: Do not try take screen recording in using FGA. It break FGA sanity.

Which is why there's an inbuilt recording feature in the app. Check More options/Advanced.

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

I would like to see the script running after turning this OFF. I believe this needs to be ON.

Yes I agree. Seperated usage guide make user painful. But i am not well knowing this environment such as android, kotlin and so on, and I can not run sainly with fullscreen flag. Just I guess android fullscreen settings make difference of screen resolution and dimension.

Does Auto detect not detect KR server now?

Need to do test. but I have no AP now. I will try that after morning.

@MathewSachin
Copy link
Collaborator

Yes I agree. Seperated usage guide make user painful. But i am not well knowing this environment such as android, kotlin and so on, and I can not run sainly with fullscreen flag. Just I guess android fullscreen settings make difference of screen resolution and dimension

I think there's a misunderstanding.
I meant to ask for a video showing the script running. You can record video from within FGA by turning it ON from More options/Advanced.

@MathewSachin
Copy link
Collaborator

@sleeping-player
Copy link

Ah, since I haven't done KR since the beginning of this year, it's difficult to test. I'm sorry for that.

@kbg0104
Copy link

kbg0104 commented Jul 26, 2021

@MathewSachin
In Galaxy S21, there was only the same result as the screenshot above.
#787 (comment)
I think it's probably a bug on this issue. #784 (comment) I think I'll have to go through a personal process.

Since then, it has been confirmed that the game works normally by running it on the full screen.

All functions worked normally in Galaxy Note 9.
There was no problem choosing friends, dungeons, or consecutive dungeons that had previously been a problem.

@reconman
Copy link
Collaborator

@kbg0104 Please do this and share the video:

@kbg0104
Copy link

kbg0104 commented Jul 26, 2021

@reconman
Everything is working normally.
The video was modified randomly due to its capacity. (Resizing and Cutting)
I used Galaxy S21.

record.mp4
record.1.mp4

@MathewSachin
Copy link
Collaborator

@Yoshinyong Can you check the apk from this page: https://github.com/Fate-Grand-Automata/FGA/suites/3328601476/artifacts/78016401
Also, reset the stage counter similarity value for this build. Don't use 100% for this one.

@item4
Copy link
Contributor Author

item4 commented Jul 26, 2021

@MathewSachin I tested auto detect server and work fine

@item4
Copy link
Contributor Author

item4 commented Jul 27, 2021

I take video record but it is too huge to upload at GitHub.

There is no problem. But sometime area detect debug box placed wrong place.

(Check @kbg0104 's first upload video)

@ScathachSkadi
Copy link
Contributor

@MathewSachin Sorry I am late. I tested the build by making the app full screen and it works perfectly. My device is S20+.

@MathewSachin MathewSachin merged commit 6309b18 into Fate-Grand-Automata:master Jul 27, 2021
@item4 item4 deleted the new_ui_kr branch July 27, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application problem due to UI change of Korean server
6 participants