Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove href from dropdown trigger #29

Closed
selvagsz opened this issue Jan 30, 2017 · 6 comments
Closed

Remove href from dropdown trigger #29

selvagsz opened this issue Jan 30, 2017 · 6 comments

Comments

@selvagsz
Copy link

What's the reason behind the href in the dropdown trigger?

react-simple-dropdown/src/components/DropdownTrigger.jsx

Line 25 in 6ac882a

<a {...props} href="#dropdown-trigger">

I'm facing issue while migrating my angular app to react. NgRouter tries to navigate when clicking on the dropdown menu
@Fauntleroy
Copy link
Owner

That's a good question! I'm gonna look into it whether or not it truly does anything...

@selvagsz
Copy link
Author

selvagsz commented Jan 30, 2017 •
edited
Loading

@Fauntleroy I'd forked & removed the href. Everything seemed to work fine. If agreed upon, I can raise a PR to the upstream

@selvagsz selvagsz mentioned this issue Jan 30, 2017
Closed
@selvagsz
Copy link
Author

selvagsz commented Feb 7, 2017

@Fauntleroy Had a chance to look into this ?

@Fauntleroy
Copy link
Owner

https://github.com/Fauntleroy/react-simple-dropdown/releases/tag/2.0.0

@Fauntleroy
Copy link
Owner

The href should no longer appear in 2.0.0. Just published to npm.

@selvagsz
Copy link
Author

selvagsz commented Feb 8, 2017

@Fauntleroy thanks

@rakeshpai rakeshpai mentioned this issue Jul 19, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fauntleroy @selvagsz