Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default settings don't get read on startup #10

Closed
daschu117 opened this issue Nov 14, 2011 · 9 comments
Closed

Default settings don't get read on startup #10

daschu117 opened this issue Nov 14, 2011 · 9 comments
Assignees
Labels

Comments

@daschu117
Copy link

@daschu117 daschu117 commented Nov 14, 2011

If you modify the default settings, they don't get read when opening PuTTYTray. Selecting "Default Settings" and clicking Load works more or less as expected it seems.

@ghost ghost assigned FauxFaux Nov 15, 2011
@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Nov 27, 2011

PuTTYTray has never supported loading default settings from file_ configs, and loading from the registry appears to work fine.

Might add support for loading default config from file at some point.

@daschu117
Copy link
Author

@daschu117 daschu117 commented Dec 4, 2011

Actually, it does support it if you create a session file named "Default%20Settings" either manually, or by saving a session named "Default Settings". All you have to do Load the "Default Settings" session and it will find your modified defaults. It would be nice if it looked for this session file on startup and loaded it automatically.

@EntityReborn
Copy link

@EntityReborn EntityReborn commented Sep 11, 2013

This is still an issue, and would be great if implemented. daschu117's "remedy" isn't really acceptable in a fast moving environment. As I run Putty (and forks) in a dropbox environment, keeping defaults in registry isn't a good solution.

@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Oct 20, 2013

I'm not especially happy with that change, but it does move us in the right direction, I believe. As early as possible, we decide whether we've got any registry settings to load. If we don't, then save that we're in filemode, and (not quite hence, but...) load the file defaults instead of the reg defaults.

@EntityReborn
Copy link

@EntityReborn EntityReborn commented Oct 20, 2013

If I understand you correctly, you check registry first, and then fallback to file. Would it be possible to default to the opposite instead? My reason being, if I take my USB install to a client's computer, and for whatever reason they have it installed on their machine, I'm left in the dark. Alternatively, search for a "portable.dat" file in the launch directory, and if it exists, default to file mode.

FauxFaux added a commit that referenced this issue Oct 30, 2013
Storage type is now a global setting.  This removes a lot of complexity.

File settings are checked by default, if they don't exist, then the
registry is honoured.

Now that it's gone, I can't see any advantages to the old code, so I'm
guessing there's a glaring omission here somewhere. (Famous last words.)
@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Oct 30, 2013

Seems sensible, @EntityReborn. Done.

And now I've gone and gutted loads more stuff. Whoopee. I'm going to close this and pretend that it all works.

@EntityReborn
Copy link

@EntityReborn EntityReborn commented Oct 30, 2013

Hah, excellent. Thank you. As I don't have a compiler on my machine, where would I go about getting a binary for this update? (If you don't have a CI, I can wait a few days)

@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Oct 30, 2013

I've uploaded a signed beta:

@EntityReborn
Copy link

@EntityReborn EntityReborn commented Oct 30, 2013

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.