New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window title empty if charset is ISO-8859-15 #109

Closed
eesau opened this Issue Oct 15, 2013 · 3 comments

Comments

3 participants
@eesau

eesau commented Oct 15, 2013

If both PuTTY and server side charset are set to ISO-8859-15 window title disappears at login and is empty no matter what. Propably has something to do with issue 88 since title is visible if charset is UTF-8. Works correctly in previous version p0.63-t017.

@FauxFaux

This comment has been minimized.

Owner

FauxFaux commented Oct 20, 2013

So this is 6fd9b21 / GH-88. I couldn't actually find any common usecases where this broke, but if people are hitting it then I will actually have another attempt.

@otanner

This comment has been minimized.

otanner commented Oct 21, 2013

I confirm this bug. I am able to get the title back if I minimize the window to tray and restore it back. Also when going to Change settings and just clicking Apply does the trick (the correct title is visible in the settings/window/behaviour). The bug doesn't need high-ascii latin1 characters to be repeated, just changing it in bash by echo -ne "\033]0;abc\007" makes the title dissappear again.

FauxFaux added a commit that referenced this issue Nov 30, 2013

Revert "GH-88", as it breaks some people (GH-109)
To be revisited at a later date.

This reverts commit 1ca64ea.
This reverts commit 445f9f5.
This reverts commit 6fd9b21.
@FauxFaux

This comment has been minimized.

Owner

FauxFaux commented Nov 30, 2013

I've reverted this code for now.

@FauxFaux FauxFaux closed this Nov 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment