Crash in safefree/ssh_channel_destroy when running ssh-add --invalid in 3f115c6 #123

Closed
voltagex opened this Issue Dec 21, 2013 · 1 comment

Projects

None yet

2 participants

@voltagex

I have a reproducible crash when:

  • Running putty.exe from 3f115c6
  • Pageant has a key loaded into memory
  • ssh agent forwarding is enabled
  • I run ssh-add --somethinginvalid (any invalid parameter will do)

I have a minidump of the crash but I am unsure if it will contain my keys - please advise.

@FauxFaux FauxFaux added a commit that referenced this issue Dec 22, 2013
@FauxFaux simon + GH-123: Fix free of an uninitialised pointer.
CHAN_AGENT channels need c->u.a.message to be either NULL or valid
dynamically allocated memory, because it'll be freed by
ssh_channel_destroy. This bug triggers if an agent forwarding channel
is opened and closed without having sent any queries.

git-svn-id: svn://svn.tartarus.org/sgt/putty@10032 cda61777-01e9-0310-a592-d414129be87e
067ed10
@FauxFaux
Owner

Fixed upstream by 98b9e75; cherry-picked into master.

@FauxFaux FauxFaux closed this Dec 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment