Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in safefree/ssh_channel_destroy when running ssh-add --invalid in 3f115c6 #123

Closed
ghost opened this issue Dec 21, 2013 · 1 comment
Closed

Comments

@ghost
Copy link

@ghost ghost commented Dec 21, 2013

I have a reproducible crash when:

  • Running putty.exe from 3f115c6
  • Pageant has a key loaded into memory
  • ssh agent forwarding is enabled
  • I run ssh-add --somethinginvalid (any invalid parameter will do)

I have a minidump of the crash but I am unsure if it will contain my keys - please advise.

FauxFaux added a commit that referenced this issue Dec 22, 2013
CHAN_AGENT channels need c->u.a.message to be either NULL or valid
dynamically allocated memory, because it'll be freed by
ssh_channel_destroy. This bug triggers if an agent forwarding channel
is opened and closed without having sent any queries.

git-svn-id: svn://svn.tartarus.org/sgt/putty@10032 cda61777-01e9-0310-a592-d414129be87e
@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Dec 22, 2013

Fixed upstream by 98b9e75; cherry-picked into master.

@FauxFaux FauxFaux closed this Dec 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant