Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

blinking icon on bell becomes transparents after opening puttytray #20

Closed
tvelter opened this Issue · 6 comments

3 participants

@tvelter

I have set puttytray to be only shown as minimized in the tray area.
When a bell is sent (screen + irssi) to putty tray, the icon blinks in the tray area, but if i click to open during a non-icon period (blinking is icon/non-icon), then on minimize the icon is transparent, thus no icon is shown but an empty area.

@FauxFaux
Owner

That patch doesn't fix the issue for me... not that I can work out why. I'll have a look.

@stfnm

Hm very strange.

Well as far as I had figured it out the problem was that if cfg.beep_ind was not set to B_IND_FLASH the variable puttyTrayFlashIcon never got any value assigned (only the default value chosen by the compiler, due to being a static variable; that's also why nothing crashes later), because the last else-if-block (to maintain the flashing) was never ever entered. Therefore upon calling flash_window(0) to stop flashing the variable still would be without any proper value and when trying to reset the trayicon things would go bad of course.

The patch solved the problem for me. :/

@FauxFaux FauxFaux closed this in 88aae02
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
b332ddc
@FauxFaux
Owner

If you double-click restore, puttyTrayVisible is already false and your code never gets run; just lifted it outside.

@FauxFaux FauxFaux referenced this issue
Closed

Fix #20 #21

@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
1461ee8
@tvelter
@FauxFaux
Owner

You probably need to wait for me to do a proper release; there's a couple of things I want to finish off first.

@tvelter
@FauxFaux FauxFaux referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
f25b39b
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
4c3ecb1
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
e998599
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
e1c93be
@FireEgl FireEgl referenced this issue from a commit in FireEgl/FuTTY
@stfnm stfnm Fix #20: initialize puttyTrayFlashIcon properly ecea910
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
f468319
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
8fe933b
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
14cc303
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
4d98fbb
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
627e9ab
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
d8e50d9
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
84cf0d2
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
ab8463b
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
8404d21
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
7ca4204
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
a93f249
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
b511a5f
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
87dde37
@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-20: Never smush our backup of the icon, and always reset it even i…
…f we're not minimised at the time
1fa6205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.