Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blinking icon on bell becomes transparents after opening puttytray #20

Closed
tvelter opened this issue Mar 8, 2012 · 6 comments
Closed

blinking icon on bell becomes transparents after opening puttytray #20

tvelter opened this issue Mar 8, 2012 · 6 comments

Comments

@tvelter
Copy link

@tvelter tvelter commented Mar 8, 2012

I have set puttytray to be only shown as minimized in the tray area.
When a bell is sent (screen + irssi) to putty tray, the icon blinks in the tray area, but if i click to open during a non-icon period (blinking is icon/non-icon), then on minimize the icon is transparent, thus no icon is shown but an empty area.

@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Mar 8, 2012

That patch doesn't fix the issue for me... not that I can work out why. I'll have a look.

@stfnm
Copy link
Contributor

@stfnm stfnm commented Mar 8, 2012

Hm very strange.

Well as far as I had figured it out the problem was that if cfg.beep_ind was not set to B_IND_FLASH the variable puttyTrayFlashIcon never got any value assigned (only the default value chosen by the compiler, due to being a static variable; that's also why nothing crashes later), because the last else-if-block (to maintain the flashing) was never ever entered. Therefore upon calling flash_window(0) to stop flashing the variable still would be without any proper value and when trying to reset the trayicon things would go bad of course.

The patch solved the problem for me. :/

@FauxFaux FauxFaux closed this in 88aae02 Mar 8, 2012
FauxFaux added a commit that referenced this issue Mar 8, 2012
@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Mar 8, 2012

If you double-click restore, puttyTrayVisible is already false and your code never gets run; just lifted it outside.

@FauxFaux FauxFaux mentioned this issue Mar 8, 2012
FauxFaux added a commit that referenced this issue Mar 12, 2012
@tvelter
Copy link
Author

@tvelter tvelter commented Mar 13, 2012

Dear Chris,

I'm not an advanced developper, how to benefit from those improvments ?
I still face the transparent icon everytime I click with wrong timing when
its blinking ...

Thank you anyway, keep up the good work !
Cheers,
Tristan

On Fri, Mar 9, 2012 at 02:08, Chris West <
reply@reply.github.com

wrote:

If you double-click restore, puttyTrayVisible is already false and your
code never gets run; just lifted it outside.


Reply to this email directly or view it on GitHub:
#20 (comment)

@FauxFaux
Copy link
Owner

@FauxFaux FauxFaux commented Mar 13, 2012

You probably need to wait for me to do a proper release; there's a couple of things I want to finish off first.

@tvelter
Copy link
Author

@tvelter tvelter commented Mar 14, 2012

Alright, I'll be aptient then.
Thanks you anyway :D

On Wed, Mar 14, 2012 at 01:16, Chris West <
reply@reply.github.com

wrote:

You probably need to wait for me to do a proper release; there's a couple
of things I want to finish off first.


Reply to this email directly or view it on GitHub:
#20 (comment)

FauxFaux added a commit that referenced this issue Apr 15, 2012
FauxFaux added a commit that referenced this issue Apr 30, 2012
FauxFaux added a commit that referenced this issue May 19, 2012
FauxFaux added a commit that referenced this issue Jun 2, 2012
FireEgl pushed a commit to FireEgl/FuTTY that referenced this issue Jun 2, 2012
FauxFaux added a commit that referenced this issue Jul 18, 2012
FauxFaux added a commit that referenced this issue Oct 4, 2012
FauxFaux added a commit that referenced this issue Oct 25, 2012
FauxFaux added a commit that referenced this issue Nov 22, 2012
FauxFaux added a commit that referenced this issue Jan 12, 2013
FauxFaux added a commit that referenced this issue Feb 8, 2013
FauxFaux added a commit that referenced this issue Mar 19, 2013
FauxFaux added a commit that referenced this issue Apr 13, 2013
FauxFaux added a commit that referenced this issue Jun 1, 2013
FauxFaux added a commit that referenced this issue Jul 13, 2013
FauxFaux added a commit that referenced this issue Jul 14, 2013
FauxFaux added a commit that referenced this issue Aug 6, 2013
FauxFaux added a commit that referenced this issue Aug 7, 2013
FauxFaux added a commit that referenced this issue Aug 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants