New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode breaks link detection #42

Closed
kuukunen opened this Issue Jun 25, 2012 · 10 comments

Comments

5 participants
@kuukunen

kuukunen commented Jun 25, 2012

I hope this comes through the internet fine...

If you type something like this:
(  ゚,_ゝ゚) http://google.fi

It will get the start of the link incorrectly and clicking it will go to http://google.f
And the Problem will be for all links after the unicode string as long as it's on screen.
And adding multiple problematic characters will shift it further, so next it will try to go to: ) http://google.

@kuukunen

This comment has been minimized.

Show comment
Hide comment
@kuukunen

kuukunen Jun 25, 2012

Oh and I'd like to mention this is absolutely infuriating on IRC channels that tend to use silly unicode. Basically none of the links work by clicking. I know people who have switched to mintty+ssh just because of that one single issue.

kuukunen commented Jun 25, 2012

Oh and I'd like to mention this is absolutely infuriating on IRC channels that tend to use silly unicode. Basically none of the links work by clicking. I know people who have switched to mintty+ssh just because of that one single issue.

@kuukunen

This comment has been minimized.

Show comment
Hide comment
@kuukunen

kuukunen Jun 25, 2012

Actually, I think it's that character causing problems: http://www.fileformat.info/info/unicode/char/3000/index.htm
As in " "

kuukunen commented Jun 25, 2012

Actually, I think it's that character causing problems: http://www.fileformat.info/info/unicode/char/3000/index.htm
As in " "

@ghost ghost assigned FauxFaux Jun 26, 2012

@FauxFaux

This comment has been minimized.

Show comment
Hide comment
@FauxFaux

FauxFaux Jun 26, 2012

Owner

Yeah, I can reproduce this. I've had a quick look and can't see an immediate fix, and will be away for a few weeks...

Owner

FauxFaux commented Jun 26, 2012

Yeah, I can reproduce this. I've had a quick look and can't see an immediate fix, and will be away for a few weeks...

FauxFaux added a commit that referenced this issue Jul 23, 2012

gh-42: Attempt (and fail) to accomodate characters that need two cols
This doesn't actually fix the problem as the wrong number of characters
end up getting added to the buffer (which really messes everything up),
and doesn't fix the arabic characters that that damn face contains, due
to some weird utf-16 encoding.

There really has to be a better way.
@incognico

This comment has been minimized.

Show comment
Hide comment
@incognico

incognico Aug 7, 2012

I can reproduce this also.

Having one line is full of the unicode 0x2500 box drawing chars and every link below the line (no matter where unicode line is) will get 'detected' one line above the actual link. So I can not highlight the link hovering over it but the text in exactly one line above. See http://i.imgur.com/Ovi6a.png - it is really annoying :P

incognico commented Aug 7, 2012

I can reproduce this also.

Having one line is full of the unicode 0x2500 box drawing chars and every link below the line (no matter where unicode line is) will get 'detected' one line above the actual link. So I can not highlight the link hovering over it but the text in exactly one line above. See http://i.imgur.com/Ovi6a.png - it is really annoying :P

@FauxFaux

This comment has been minimized.

Show comment
Hide comment
@FauxFaux

FauxFaux Aug 8, 2012

Owner

Yeah, that's the same bug. The code is just so wrong that it's funny.

Owner

FauxFaux commented Aug 8, 2012

Yeah, that's the same bug. The code is just so wrong that it's funny.

twpol added a commit to twpol/PuTTYTray that referenced this issue Aug 23, 2012

@FauxFaux

This comment has been minimized.

Show comment
Hide comment
@FauxFaux

FauxFaux Aug 27, 2012

Owner

@twpol's fix looks good; will test for a while then release.

Owner

FauxFaux commented Aug 27, 2012

@twpol's fix looks good; will test for a while then release.

@FauxFaux FauxFaux closed this Aug 27, 2012

@FauxFaux

This comment has been minimized.

Show comment
Hide comment
@FauxFaux

FauxFaux Sep 10, 2012

Owner

Right, apparently "∀" still breaks it. I'm guessing it's a double-width character that chooses to render as single width.
U+0500, Ԁ, Lu, CYRILLIC CAPITAL LETTER KOMI DE too.
益 the other way.

Owner

FauxFaux commented Sep 10, 2012

Right, apparently "∀" still breaks it. I'm guessing it's a double-width character that chooses to render as single width.
U+0500, Ԁ, Lu, CYRILLIC CAPITAL LETTER KOMI DE too.
益 the other way.

@twpol

This comment has been minimized.

Show comment
Hide comment
@twpol

twpol Sep 11, 2012

Contributor

The problem with the original fix was that it worked entirely by chance on the particular Unicode face given; this new fix is wholy better. :)

Contributor

twpol commented Sep 11, 2012

The problem with the original fix was that it worked entirely by chance on the particular Unicode face given; this new fix is wholy better. :)

@Berzerker

This comment has been minimized.

Show comment
Hide comment
@Berzerker

Berzerker Oct 7, 2012

Is there a built exe that someone can link for this? Or is there a link somewhere? Thanks.

Berzerker commented Oct 7, 2012

Is there a built exe that someone can link for this? Or is there a link somewhere? Thanks.

FauxFaux added a commit that referenced this issue Oct 8, 2012

@FauxFaux

This comment has been minimized.

Show comment
Hide comment
@FauxFaux

FauxFaux Oct 8, 2012

Owner

This should be fixed as of p0.62-t011. Any more issues, open new bugs!

Owner

FauxFaux commented Oct 8, 2012

This should be fixed as of p0.62-t011. Any more issues, open new bugs!

@FauxFaux FauxFaux closed this Oct 8, 2012

FauxFaux added a commit that referenced this issue Mar 19, 2013

FauxFaux added a commit that referenced this issue Mar 20, 2013

FauxFaux added a commit that referenced this issue Apr 13, 2013

FauxFaux added a commit that referenced this issue Jun 1, 2013

FauxFaux added a commit that referenced this issue Jul 13, 2013

FauxFaux added a commit that referenced this issue Jul 14, 2013

FauxFaux added a commit that referenced this issue Aug 6, 2013

FauxFaux added a commit that referenced this issue Aug 7, 2013

FauxFaux added a commit that referenced this issue Aug 11, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment