Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Unicode breaks link detection #42

Closed
kuukunen opened this Issue · 10 comments

5 participants

@kuukunen

I hope this comes through the internet fine...

If you type something like this:
(  ゚,_ゝ゚) http://google.fi

It will get the start of the link incorrectly and clicking it will go to http://google.f
And the Problem will be for all links after the unicode string as long as it's on screen.
And adding multiple problematic characters will shift it further, so next it will try to go to: ) http://google.

@kuukunen

Oh and I'd like to mention this is absolutely infuriating on IRC channels that tend to use silly unicode. Basically none of the links work by clicking. I know people who have switched to mintty+ssh just because of that one single issue.

@kuukunen

Actually, I think it's that character causing problems: http://www.fileformat.info/info/unicode/char/3000/index.htm
As in " "

@FauxFaux FauxFaux was assigned
@FauxFaux
Owner

Yeah, I can reproduce this. I've had a quick look and can't see an immediate fix, and will be away for a few weeks...

@FauxFaux FauxFaux referenced this issue from a commit
@FauxFaux gh-42: Attempt (and fail) to accomodate characters that need two cols
This doesn't actually fix the problem as the wrong number of characters
end up getting added to the buffer (which really messes everything up),
and doesn't fix the arabic characters that that damn face contains, due
to some weird utf-16 encoding.

There really has to be a better way.
5b35aff
@incognico

I can reproduce this also.

Having one line is full of the unicode 0x2500 box drawing chars and every link below the line (no matter where unicode line is) will get 'detected' one line above the actual link. So I can not highlight the link hovering over it but the text in exactly one line above. See http://i.imgur.com/Ovi6a.png - it is really annoying :P

@FauxFaux
Owner

Yeah, that's the same bug. The code is just so wrong that it's funny.

@twpol twpol referenced this issue from a commit in twpol/PuTTYTray
@twpol twpol gh-42: Fix for wide (two-cell) characters messing up the URL detectio…
…n boxes.
fb9d2a8
@FauxFaux
Owner

@twpol's fix looks good; will test for a while then release.

@FauxFaux FauxFaux closed this
@FauxFaux
Owner

Right, apparently "∀" still breaks it. I'm guessing it's a double-width character that chooses to render as single width.
U+0500, Ԁ, Lu, CYRILLIC CAPITAL LETTER KOMI DE too.
益 the other way.

@FauxFaux FauxFaux reopened this
@twpol twpol referenced this issue from a commit in twpol/PuTTYTray
@twpol twpol gh-42: Better, more reliable fix for link hitboxes being misaligned o…
…n wide-drawn characters.
2bac09b
@twpol

The problem with the original fix was that it worked entirely by chance on the particular Unicode face given; this new fix is wholy better. :)

@Berzerker

Is there a built exe that someone can link for this? Or is there a link somewhere? Thanks.

@FauxFaux
Owner

This should be fixed as of p0.62-t011. Any more issues, open new bugs!

@FauxFaux FauxFaux closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.