Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Fixing a bug in fetching session list from files #131

Closed
wants to merge 1 commit into from

Conversation

shobhitg
Copy link

While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.

While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.
@shobhitg
Copy link
Author

Anyone up for review?

FauxFaux pushed a commit that referenced this pull request Feb 21, 2014
While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.
@FauxFaux
Copy link
Owner

Thanks!

@FauxFaux FauxFaux closed this Feb 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants