Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing a bug in fetching session list from files #131

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@shobhitg
Copy link

shobhitg commented Jan 25, 2014

While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.

Fixing a bug in fetching session list from files
While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.
@shobhitg

This comment has been minimized.

Copy link
Author

shobhitg commented Jan 27, 2014

Anyone up for review?

FauxFaux added a commit that referenced this pull request Feb 21, 2014

GH-131: Ignore folders while fetching file sessions
While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.
@FauxFaux

This comment has been minimized.

Copy link
Owner

FauxFaux commented Feb 21, 2014

Thanks!

@FauxFaux FauxFaux closed this Feb 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.