Fixing a bug in fetching session list from files #131

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@shobhitg

While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.

@shobhitg shobhitg Fixing a bug in fetching session list from files
While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.
fd950b9
@shobhitg

Anyone up for review?

@FauxFaux FauxFaux added a commit that referenced this pull request Feb 21, 2014
@shobhitg @FauxFaux shobhitg + GH-131: Ignore folders while fetching file sessions
While fetching session list from files, ignore folders and fetch next
available session file instead of returning null.

If you happen to have a stray folder in the sessions folder, then the
order in which FindNextFile() gets files is uncertain. And often we end up
seeing a folder traversed in the middle of several session files.

This issue is easily reproducable if we have lots of session files that
start with different names and a folder.
9204b15
@FauxFaux
Owner

Thanks!

@FauxFaux FauxFaux closed this Feb 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment