Use two rows for "Connection type" in Session menu #27
Conversation
When the "Adb" connection type was added the radio buttons got extremely squashed together and it was no longer possible to read their labels completely. Therefore splitting them into two rows seemed like a good idea to me. Since the space was quite limited already I also increased the entire height of the config dialog box by 10. This appeared to be the better option instead of making the "Sessions" control smaller in its height.
|
Merged as 4c9f70e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
When the "Adb" connection type was added the radio buttons got
extremely squashed together and it was no longer possible to read
their labels completely. Therefore splitting them into two rows
seemed like a good idea to me.
Since the space was quite limited already I also increased the
entire height of the config dialog box by 10. This appeared to be
the better option instead of making the "Sessions" control smaller
in its height.