Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from bitcoin/master #366

Merged
merged 141 commits into from Oct 11, 2018

Conversation

Projects
None yet
@Bushstar
Copy link
Collaborator

commented Oct 11, 2018

[Net] Switch nPrevNodeCount to vNodesSize
bitcoin/bitcoin#14140

doc: correct GetDifficulty doc
bitcoin/bitcoin#14135

lint: Make sure we read the command line inputs using utf-8 decoding in python
bitcoin/bitcoin#14128

refactoring: Remove unreferenced local variables
bitcoin/bitcoin#14094

[doc] Add new regtest ports in man following #10825 ports reattributions
bitcoin/bitcoin#14013

gui: Favor macOS show / hide action in dock menu
bitcoin/bitcoin#14133

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
bitcoin/bitcoin#13249

appveyor: Use clcache to speed up build
bitcoin/bitcoin#14086

lint: Make all linters work under the default macOS dev environment (build-osx.md)
bitcoin/bitcoin#14115

doc: Change documentation for =0 for non-boolean options
bitcoin/bitcoin#14100

Warn (don't fail!) on spelling errors. Fix typos reported by codespell.
bitcoin/bitcoin#13954

util: Report parse errors in configuration file
bitcoin/bitcoin#14105

Add reference documentation for descriptors language
bitcoin/bitcoin#14096

doc: Remove misleading checkpoints comment in CMainParams
bitcoin/bitcoin#14149

[Wallet] [RPC] Remove deprecated wallet rpc features from bitcoin_server
bitcoin/bitcoin#12490

Docs: Add disable-wallet section to OSX build instructions, update line in Unix instructions
bitcoin/bitcoin#14153

Explain when reindex-chainstate can be used instead of reindex
bitcoin/bitcoin#13662

Integration of property based testing into Bitcoin Core
bitcoin/bitcoin#12775

qa: Read reject reasons from debug log, not p2p messages
bitcoin/bitcoin#14119

bitcoin-cli: don't translate command line options
bitcoin/bitcoin#14186

[Logging] Only log "Using config file PATH_TO_bitcoin.conf" message on startup if conf file exists
bitcoin/bitcoin#14057

Update univalue subtree
bitcoin/bitcoin#14164

depends: Remove unused Qt 4 dependencies
bitcoin/bitcoin#14183

p2p: Disable BIP 61 by default
bitcoin/bitcoin#14054

wallet: Set encrypted_batch to nullptr after delete. Avoid double free in the case of NDEBUG.
bitcoin/bitcoin#14138

build: avoid getifaddrs when unavailable
bitcoin/bitcoin#14127

Preserve a format of RPC command definitions
bitcoin/bitcoin#14008

tx pool: Use class methods to hide raw map iterator impl details
bitcoin/bitcoin#13793

Let wallet importmulti RPC accept labels for standard scriptPubKeys
bitcoin/bitcoin#9332

qa: Fix silent merge conflict in wallet_importmulti
bitcoin/bitcoin#14189

gui: Also log and print messages or questions like bitcoind
bitcoin/bitcoin#14162

utils: Use _wfopen and _wfreopen on Windows
bitcoin/bitcoin#13866

Drop unused GetType() from CSizeComputer
bitcoin/bitcoin#13558

[tests] Speed up knapsack_solver_test by not recreating wallet 100 times.
bitcoin/bitcoin#13419

Scripts and tools: increased timeout downloading
bitcoin/bitcoin#14184

gui: Drop boost::scoped_array and use wchar_t API explicitly on Windows
bitcoin/bitcoin#13734

Remove ENABLE_WALLET from libbitcoin_server.a
bitcoin/bitcoin#14168

utils: run commands using utf-8 string on Windows
bitcoin/bitcoin#13886

build: Move interfaces/* to libbitcoin_server
bitcoin/bitcoin#14204

logging: Replace LogPrint macros with regular functions
bitcoin/bitcoin#14209

doc: -help-debug implies -help
bitcoin/bitcoin#14207

Call unicode API on Windows
bitcoin/bitcoin#13888

qa: Run all tests even if wallet is not compiled
bitcoin/bitcoin#14180

[psbt]Remove redundant BIP174 test from rpc_psbt.json
bitcoin/bitcoin#14199

Report progress in ReplayBlocks while rolling forward
bitcoin/bitcoin#13310

rpc: Return more specific reject reason for submitblock
bitcoin/bitcoin#13983

[build] Actually remove ENABLE_WALLET
bitcoin/bitcoin#14208

utils: Convert fs::filesystem_error messages from local multibyte to utf-8 on Windows
bitcoin/bitcoin#14192

Docs: Fix reference to lint-locale-dependence.sh
bitcoin/bitcoin#14213

qa: Fixups to "Run all tests even if wallet is not compiled"
bitcoin/bitcoin#14179

[qa] Use correct python index slices in example test
bitcoin/bitcoin#14215

[wallet] Reopen CDBEnv after encryption instead of shutting down
bitcoin/bitcoin#12493

doc: Document -checklevel levels
bitcoin/bitcoin#14206

build: Remove libssl from LDADD unless gui
bitcoin/bitcoin#14212

tests: Reorder tests and move most of extended tests up to normal tests
bitcoin/bitcoin#14225

integer division instead of implicit double conversion
bitcoin/bitcoin#14227

[depends, zmq, doc] upgrade zeromq to 4.2.5 and avoid deprecated zeromq api functions
bitcoin/bitcoin#13578

qa: generate --> generatetoaddress change to allow tests run without wallet
bitcoin/bitcoin#14236

Fix crash bug with duplicate inputs within a transaction
bitcoin/bitcoin#14247

doc: Add historical release notes for 0.16.3
bitcoin/bitcoin#14251

[rpc] Add getnodeaddresses RPC command
bitcoin/bitcoin#13152

tests: Use MakeUnique to construct objects owned by unique_ptrs
bitcoin/bitcoin#14287

convert C-style (void) parameter lists to C++ style ()
bitcoin/bitcoin#14214

doc: Add autogen.sh in ARM Cross-compilation
bitcoin/bitcoin#14276

init: Remove deprecated args from hidden args
bitcoin/bitcoin#14272

wallet: Fix use of uninitialized value bnb_used in CWallet::CreateTransaction(...)
bitcoin/bitcoin#13546

[REST] improve performance for JSON calls
bitcoin/bitcoin#14298

[RPC] Remove warning for removed estimatefee RPC
bitcoin/bitcoin#14297

Consistently validate txid / blockhash length and encoding in rpc calls
bitcoin/bitcoin#13424

tests: Run functional test on Windows and enable it on Appveyor
bitcoin/bitcoin#14007

Don't edit Chainparams after initialization
bitcoin/bitcoin#13311

tests: Write the notification message to different files to avoid race condition in feature_notifications.py
bitcoin/bitcoin#14275

AppVeyor: Move AppVeyor YAML to dot-file-style YAML
bitcoin/bitcoin#14306

lcov: filter /usr/lib/ from coverage reports
bitcoin/bitcoin#14281

utils: Make fs::path::string() always return utf-8 string on Windows
bitcoin/bitcoin#13877

[wallet] Ensure wallet is unlocked before signing
bitcoin/bitcoin#14310

[wallet] Remove -usehd
bitcoin/bitcoin#14282

Tests: enforce critical class instance attributes in functional tests, fix segwit test specificity
bitcoin/bitcoin#14305

Bugfix: Only run bitcoin-tx tests when bitcoin-tx is enabled
bitcoin/bitcoin#12246

Skip stale tip checking if outbound connections are off or if reindexing.
bitcoin/bitcoin#14027

Consolidate redundant implementations of ParseHashStr
bitcoin/bitcoin#14307

amount: Move CAmount CENT to unit test header
bitcoin/bitcoin#14244

tests: exclude all tests with difference parameters in --exclude list
bitcoin/bitcoin#14316

doc: Add GitHub pr template
bitcoin/bitcoin#14217

depends: fix bitcoin-qt back-compat with older freetype versions at runtime
bitcoin/bitcoin#14348

doxygen: Fix member comments
bitcoin/bitcoin#14331

[gitian] use versioned unsigned tarballs instead of generically named ones
bitcoin/bitcoin#14325

test: Add missing call to skip_if_no_cli()
bitcoin/bitcoin#14381

doc: Split depends installation instructions per arch
bitcoin/bitcoin#14264

doc: add missing apt-get install
bitcoin/bitcoin#14393

Fix typos and cleanup
bitcoin/bitcoin#14395

utils: Convert Windows args to utf-8 string
bitcoin/bitcoin#13883

Fix path to doc/descriptors.md in 0.17 release notes
bitcoin/bitcoin#14421

tests: Don't access out of bounds array index: array[sizeof(array)]
bitcoin/bitcoin#14398

[tests] Remove rpc_zmq.py
bitcoin/bitcoin#14419

appveyor: script improvement
bitcoin/bitcoin#14241

tests: Allow closed rpc handler in assert_start_raises_init_error
bitcoin/bitcoin#14413

qa: Run more tests with wallet disabled
bitcoin/bitcoin#14324

docs: Fix macOS files description in qt/README.md
bitcoin/bitcoin#14428

docs: release process: RPC documentation
bitcoin/bitcoin#14390

Build: during 'make clean', remove some files that are currently missed.
bitcoin/bitcoin#14253

test: allow arguments to be forwarded to flake8 in lint-python.sh
bitcoin/bitcoin#13649

depends: qt: avoid system harfbuzz and bz2
bitcoin/bitcoin#14385

addrman: Add Clang thread safety annotations for variables guarded by CAddrMan.cs
bitcoin/bitcoin#13115

pstratem and others added some commits Aug 31, 2018

Switch nPrevNodeCount to vNodesSize.
These both have the same value, but the variable naming is confusing.
Increase signal to noise in appveyor build output by reducing the MSV…
…C warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented).

This makes it easier to spot errors or more important warnings in the verbose appveyor output.

See bitcoin/bitcoin#14086 (comment) plus discussion for context.
Add new regtest ports in doc following #10825 ports reattributions
Add checkmempool and checkblockindex regtest true in doc
Make objects in range declarations immutable by default. Avoid unnece…
…ssary copying of objects in range declarations.
macOS fix: Check for correct version of flake8 to avoid spurious warn…
…ings. The brew installed flake8 version is Python 2 based and does not work.
doc: Change documentation for =0 for non-boolean options
PR #12713 changed the interpretation for negation of non-boolean options
(e.g. -noconnect) to no longer set the option to 0, but to remove it
from the options.

I think this is better because it gets rid of the special meaning of
'0'.

However it needs to be documented. I attempt to do so in this PR.
Addreses #14064.
util: Report parse errors in configuration file
Report errors while parsing the configuration file, instead of silently
ignoring them.

    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: nodebuglogfile, if you intended to specify a negated option, use nodebuglogfile=1 instead
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 22: sdafsdfafs
    $ src/bitcoind -regtest
    Error reading configuration file: parse error on line 24: -nodebuglogfile=1, options in the configuration file must be specified without leading -
[RPC] Remove warning about wallet addresses in createmultisig()
createmultisig() was updated in V0.16 to not use the wallet. Warning
text was included to warn the user. Remove that now.
Integration of property based testing into Bitcoin Core
update copyright headers

attempt to fix linting errors

Fixing issue with make check classifying generator files as actual unit tests

Wrapping gen files in ENABLE_PROPERTY_TESTS macro

Make macro better

theuni and others added some commits Sep 28, 2018

depends: fix bitcoin-qt back-compat with older freetype versions at r…
…untime

A few years ago, libfreetype introduced FT_Get_Font_Format() as an alias for
FT_Get_X11_Font_Format(), but FT_Get_X11_Font_Format() was kept for abi
backwards-compatibility.

Our qt bump to 5.9 introduced a call to FT_Get_Font_Format(). Replace it with
FT_Get_X11_Font_Format() in order to remain compatibile with older freetype,
which is still used by e.g. Ubuntu Trusty.
[gitian] use versioned unsigned tarballs instead of generically named…
… ones

Instead of re-naming the tarballs used for the code signing step to the generically
named tarball that is used, keep the versioned naming. Only copy them to the
correct filename when they are needed at build time.
[tests] Remove rpc_zmq.py
rpc_zmq.py is racy and fails intermittently. Remove that test file and
move the getzmqnotifications RPC test into interface_zmq.py
depends: qt: avoid system harfbuzz and bz2
We may eventually want to break out harfbuzz and build it in depends, but
for now just ensure that runtime dependencies don't depend on whether or not
harfbuzz was present on the builder.
build: bump version to 0.17.99
Now that 0.17 branch has been split off, master is 0.17.99 (pre-0.18).

Also clean out release notes.

Tree-SHA512: bb20025d3ead3346afc7a6a51af715783e705e1de9d1b90ced6423d8969d64e42b72d06a1eb853083b11e9cfe674775266792ae2cd18ed6c858938e125edab03

@Bushstar Bushstar merged commit 79cca8d into FeatherCoin:master Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.