Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better cli info #525

Merged
merged 11 commits into from Jun 18, 2019
Merged

Better cli info #525

merged 11 commits into from Jun 18, 2019

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented May 1, 2019

  • create a show_info function, which can be directly called featuretools.show_info() in python
  • featuretools info CLI click command calls that show_info function

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #525 into master will decrease coverage by 0.05%.
The diff coverage is 47.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage    96.4%   96.34%   -0.06%     
==========================================
  Files         119      119              
  Lines        9643     9661      +18     
==========================================
+ Hits         9296     9308      +12     
- Misses        347      353       +6
Impacted Files Coverage Δ
featuretools/primitives/utils.py 97.19% <ø> (-0.06%) ⬇️
featuretools/utils/trie.py 100% <ø> (ø) ⬆️
...s/computational_backends/feature_set_calculator.py 98.07% <ø> (ø) ⬆️
...ools/tests/primitive_tests/test_primitive_utils.py 100% <ø> (ø) ⬆️
featuretools/__main__.py 0% <0%> (ø) ⬆️
featuretools/utils/api.py 100% <100%> (ø) ⬆️
featuretools/__init__.py 66.66% <100%> (+1.14%) ⬆️
featuretools/tests/utils_tests/test_cli_utils.py 100% <100%> (ø) ⬆️
featuretools/utils/cli_utils.py 55.31% <32.14%> (-34.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b84b66...098772b. Read the comment docs.

@gsheni gsheni self-assigned this Jun 18, 2019
@kmax12 kmax12 self-requested a review June 18, 2019 14:39
kmax12
kmax12 previously approved these changes Jun 18, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kmax12
kmax12 previously approved these changes Jun 18, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, otherwise LGTM

featuretools/utils/cli_utils.py Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni merged commit 26bf38b into master Jun 18, 2019
@gsheni gsheni deleted the better_cli_info branch June 18, 2019 21:39
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants