Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Variable Types #571

Merged
merged 9 commits into from Jun 4, 2019
Merged

Custom Variable Types #571

merged 9 commits into from Jun 4, 2019

Conversation

allisonportis
Copy link
Contributor

Issue #560

Added to entityset/deserialize.py so that description_to_variable() looks at all variables that are (recursively) a subclass of Variable, so that it will recognize custom variable types.

@codecov
Copy link

codecov bot commented May 30, 2019

Codecov Report

Merging #571 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   96.43%   96.44%   +<.01%     
==========================================
  Files         117      117              
  Lines        9518     9534      +16     
==========================================
+ Hits         9179     9195      +16     
  Misses        339      339
Impacted Files Coverage Δ
featuretools/entityset/serialize.py 100% <ø> (ø) ⬆️
...etools/tests/entityset_tests/test_serialization.py 96.84% <100%> (+0.59%) ⬆️
featuretools/primitives/utils.py 97.24% <100%> (-0.13%) ⬇️
featuretools/utils/gen_utils.py 89.79% <100%> (+1.15%) ⬆️
featuretools/entityset/deserialize.py 100% <100%> (ø) ⬆️
featuretools/variable_types/variable.py 98.21% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f75909...3f28790. Read the comment docs.

featuretools/entityset/serialize.py Outdated Show resolved Hide resolved
featuretools/entityset/serialize.py Outdated Show resolved Hide resolved
featuretools/entityset/deserialize.py Outdated Show resolved Hide resolved
featuretools/entityset/serialize.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@allisonportis
Copy link
Contributor Author

Hi @bschreck, we implemented a solution for custom variable types. Would you mind testing out this branch and see if it's working for you? Thanks!

@bschreck
Copy link
Contributor

bschreck commented Jun 4, 2019

@allisonportis This works great, thanks for the change!

@allisonportis allisonportis merged commit 1c00b98 into master Jun 4, 2019
@allisonportis allisonportis deleted the custom_variable_types branch June 4, 2019 22:16
@rwedge rwedge mentioned this pull request Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants