New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove entity_from_csv
, tests, and lint
#71
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
=========================================
+ Coverage 87.07% 87.5% +0.43%
=========================================
Files 75 75
Lines 7186 7147 -39
=========================================
- Hits 6257 6254 -3
+ Misses 929 893 -36
Continue to review full report at Codecov.
|
@@ -4,7 +4,6 @@ | |||
from builtins import range, zip | |||
from collections import defaultdict | |||
|
|||
import dask.dataframe as dd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove dask as a dependency in featuretools now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it. The only other use is in load_flight
which gets used in the approximate features docs page (but with a limit on the number of rows). We could just put a hard cap on the number of rows and then not require dask
projectwide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's okay to have a dask as an optional requirement to run the demos. we just need to indicate that in the docstring of load_flight and add to the installation page that dask is an optional requirement for running demos.
we also need to put a try catch around the import of dask in the demo files to avoid errors if users don't have it.
featuretools/entityset/entityset.py
Outdated
@@ -299,7 +298,8 @@ def add_column(self, entity_id, column_id, column_data, type=None): | |||
""" | |||
Add variable to entity's dataframe | |||
""" | |||
self.entity_stores[entity_id].add_column(column_id, column_data, type=type) | |||
self.entity_stores[entity_id].add_column( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you undo your line length changes for now? We currently allow lines to go beyond 80 characters in special cases like this one and edits below
0dfe0c1
to
21629cd
Compare
looks good to me! |
Removes
entity_from_csv
as discussed in #57