Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL for Compose #716

Merged
merged 4 commits into from Aug 28, 2019

Conversation

@jeff-hernandez
Copy link
Collaborator

commented Aug 27, 2019

This PR will update the URL for Compose.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@jeff-hernandez jeff-hernandez requested a review from rwedge Aug 27, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 27, 2019

Codecov Report

Merging #716 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         118      118           
  Lines       10201    10201           
=======================================
  Hits         9960     9960           
  Misses        241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd1df0...ba309c8. Read the comment docs.

@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Aug 28, 2019

Looks good. Can you add the other standard categories (Enhancements, Fixes, etc.) to the Future Release section?

docs/source/changelog.rst Outdated Show resolved Hide resolved
@rwedge
rwedge approved these changes Aug 28, 2019
Copy link
Collaborator

left a comment

Looks good

@jeff-hernandez

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 28, 2019

Updated with standard categories

@jeff-hernandez jeff-hernandez merged commit 46bd32d into master Aug 28, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 1fd1df0...ba309c8
Details
codecov/project 97.63% remains the same compared to 1fd1df0
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@jeff-hernandez jeff-hernandez deleted the compose branch Aug 28, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.