Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how files are copied and written #721

Merged
merged 4 commits into from Sep 3, 2019

Conversation

@kmax12
Copy link
Contributor

commented Aug 30, 2019

No need to iterate line by line when there are more optimized method. This PR uses them

@kmax12 kmax12 requested a review from rwedge Aug 30, 2019
@kmax12 kmax12 changed the title Improve how copies are copied and written Improve how files are copied and written Aug 30, 2019
@codecov

This comment has been minimized.

Copy link

commented Aug 30, 2019

Codecov Report

Merging #721 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #721      +/-   ##
==========================================
- Coverage   97.63%   97.63%   -0.01%     
==========================================
  Files         118      118              
  Lines       10201    10194       -7     
==========================================
- Hits         9960     9953       -7     
  Misses        241      241
Impacted Files Coverage Δ
featuretools/utils/gen_utils.py 93.4% <100%> (-0.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3195659...f33e823. Read the comment docs.

@rwedge
rwedge approved these changes Sep 3, 2019
Copy link
Collaborator

left a comment

Looks good

@kmax12 kmax12 merged commit 7d9da15 into master Sep 3, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.63%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.36% compared to 3195659
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the improve-file-copy-write branch Sep 6, 2019
@kmax12 kmax12 restored the improve-file-copy-write branch Sep 11, 2019
@kmax12 kmax12 deleted the improve-file-copy-write branch Sep 11, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.