Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of rows to plot of entityset #727

Merged

Conversation

@MarcoGorelli
Copy link
Contributor

commented Sep 4, 2019

Pull Request Description

Add number of rows to graph of entityset, closes #722


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Sep 4, 2019

Would you be willing to add a test case that checks the number of rows reported in the graph and checks the single row edge case?

@MarcoGorelli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Sure - will do!

@codecov

This comment has been minimized.

Copy link

commented Sep 5, 2019

Codecov Report

Merging #727 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
+ Coverage   97.63%   97.64%   +<.01%     
==========================================
  Files         118      118              
  Lines       10205    10222      +17     
==========================================
+ Hits         9964     9981      +17     
  Misses        241      241
Impacted Files Coverage Δ
featuretools/entityset/entityset.py 95.59% <100%> (+0.01%) ⬆️
...eaturetools/tests/entityset_tests/test_plotting.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de04288...9f8c105. Read the comment docs.

@MarcoGorelli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@rwedge How should graphviz output be tested? I've tried with a regular expression, please let me know if there's a better way / you'd like this done differently

@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

@MarcoGorelli the tests look good, thanks! Could you add yourself the list of contributors for the upcoming release in the changelog?

@rwedge
rwedge approved these changes Sep 6, 2019
Copy link
Collaborator

left a comment

Looks good! Thanks for the contribution!

@rwedge rwedge merged commit 3951bfe into FeatureLabs:master Sep 6, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.63%)
Details
codecov/project 97.64% (+<.01%) compared to de04288
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@MarcoGorelli MarcoGorelli deleted the MarcoGorelli:add-n-rows-to-graph-of-entityset branch Sep 6, 2019
@MarcoGorelli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

Happy to help, thank you for your tool!

@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.