Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for pd.DateOffset in DFS #732

Merged
merged 34 commits into from Sep 25, 2019

Conversation

@christopherbunn
Copy link
Contributor

commented Sep 6, 2019

Adds support for pd.DateOffset in DFS parameters (#729)

@codecov

This comment has been minimized.

Copy link

commented Sep 6, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@07f6379). Click here to learn what that means.
The diff coverage is 98.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #732   +/-   ##
=========================================
  Coverage          ?   97.68%           
=========================================
  Files             ?      118           
  Lines             ?    10543           
  Branches          ?        0           
=========================================
  Hits              ?    10299           
  Misses            ?      244           
  Partials          ?        0
Impacted Files Coverage Δ
...aturetools/tests/primitive_tests/test_agg_feats.py 99.41% <100%> (ø)
...aturetools/tests/entityset_tests/test_timedelta.py 100% <100%> (ø)
.../tests/primitive_tests/test_features_serializer.py 100% <100%> (ø)
featuretools/computational_backends/feature_set.py 100% <100%> (ø)
featuretools/feature_base/features_serializer.py 98.03% <100%> (ø)
featuretools/feature_base/feature_base.py 97.87% <100%> (ø)
featuretools/utils/wrangle.py 76.84% <100%> (ø)
featuretools/tests/synthesis/test_dfs_method.py 100% <100%> (ø)
...s/computational_backends/feature_set_calculator.py 98.23% <100%> (ø)
featuretools/entityset/entity.py 96.09% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07f6379...f4b5b14. Read the comment docs.

Copy link
Contributor

left a comment

Looks good so far and left some comments!

featuretools/computational_backends/feature_set.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_agg_feats.py Outdated Show resolved Hide resolved
featuretools/tests/primitive_tests/test_agg_feats.py Outdated Show resolved Hide resolved
featuretools/utils/wrangle.py Show resolved Hide resolved
featuretools/entityset/timedelta.py Outdated Show resolved Hide resolved
featuretools/entityset/timedelta.py Show resolved Hide resolved
featuretools/entityset/serialize.py Outdated Show resolved Hide resolved
}

_readable_to_unit = {v.lower(): k for k, v in _readable_units.items()}

def __init__(self, value, unit=None):
def __init__(self, value, unit=None, delta_obj=None):

This comment has been minimized.

Copy link
@rwedge

rwedge Sep 25, 2019

Collaborator

Should we document the delta_obj parameter?

This comment has been minimized.

Copy link
@christopherbunn

christopherbunn Sep 25, 2019

Author Contributor

I think we should so it's clear that it's more for _check_timedelta() and it's not necessary if a user only wants to use value and units to instantiate.

@rwedge
rwedge approved these changes Sep 25, 2019
@christopherbunn christopherbunn merged commit 5456944 into master Sep 25, 2019
4 checks passed
4 checks passed
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@christopherbunn christopherbunn deleted the dfs-pd-dateoffset branch Sep 25, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.