Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for feature-specific top_n in encode_features #735

Merged
merged 6 commits into from Sep 10, 2019

Conversation

@angela97lin
Copy link
Contributor

commented Sep 10, 2019

Adding support for passing in dictionary as top_n for feature-specific top_n in encode_features (#505)

@angela97lin angela97lin requested a review from rwedge Sep 10, 2019
@CLAassistant

This comment has been minimized.

Copy link

commented Sep 10, 2019

CLA assistant check
All committers have signed the CLA.

@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

@angela97lin can you merge the latest master into your branch and resolve the conflicts?

@codecov

This comment has been minimized.

Copy link

commented Sep 10, 2019

Codecov Report

Merging #735 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   97.64%   97.65%   +<.01%     
==========================================
  Files         118      118              
  Lines       10249    10279      +30     
==========================================
+ Hits        10008    10038      +30     
  Misses        241      241
Impacted Files Coverage Δ
featuretools/synthesis/encode_features.py 98.5% <100%> (+0.06%) ⬆️
...aturetools/tests/synthesis/test_encode_features.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac826ea...11e2ef2. Read the comment docs.

angela97lin added 3 commits Sep 10, 2019
featuretools/synthesis/encode_features.py Outdated Show resolved Hide resolved
featuretools/tests/synthesis/test_encode_features.py Outdated Show resolved Hide resolved
featuretools/tests/synthesis/test_encode_features.py Outdated Show resolved Hide resolved
featuretools/synthesis/encode_features.py Outdated Show resolved Hide resolved
featuretools/tests/synthesis/test_encode_features.py Outdated Show resolved Hide resolved
@rwedge
rwedge approved these changes Sep 10, 2019
Copy link
Collaborator

left a comment

Looks good!

@angela97lin angela97lin merged commit 1bc7856 into master Sep 10, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.64%)
Details
codecov/project 97.65% (+<.01%) compared to ac826ea
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@angela97lin angela97lin deleted the different_top_n branch Sep 10, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.