Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding progress_callback parameter to dfs() and calculate_feature_matrix(), removing time remaining #739

Merged
merged 14 commits into from Sep 16, 2019

Conversation

@angela97lin
Copy link
Contributor

commented Sep 13, 2019

Addresses #705 and #736 by adding progress_callback parameter to dfs() and calculate_feature_matrix() and removing time remaining field from the progress bar in verbose=True mode.

@codecov

This comment has been minimized.

Copy link

commented Sep 13, 2019

Codecov Report

Merging #739 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   97.66%   97.69%   +0.03%     
==========================================
  Files         118      118              
  Lines       10289    10340      +51     
==========================================
+ Hits        10049    10102      +53     
+ Misses        240      238       -2
Impacted Files Coverage Δ
...s/computational_backends/feature_set_calculator.py 98.23% <ø> (ø) ⬆️
featuretools/synthesis/dfs.py 100% <ø> (ø) ⬆️
featuretools/tests/synthesis/test_dfs_method.py 100% <100%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 98.93% <100%> (+0.79%) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.37% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6873c...5af16dd. Read the comment docs.

@angela97lin angela97lin requested review from kmax12 and rwedge Sep 13, 2019
@angela97lin angela97lin requested a review from kmax12 Sep 13, 2019
@kmax12
kmax12 approved these changes Sep 16, 2019
Copy link
Contributor

left a comment

LGTM! Go ahead and merge

@angela97lin angela97lin merged commit 8b7a2e6 into master Sep 16, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@angela97lin angela97lin deleted the progress_callback branch Sep 16, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.