Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pytest-runner and setup.py test support #741

Merged
merged 4 commits into from Sep 16, 2019

Conversation

@rwedge
Copy link
Collaborator

commented Sep 13, 2019

Pull Request Description

Removes our configuration files for setup.py test and drops pytest-runner as a setup requirement. To run the unit tests call make lint or pytest.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

rwedge added 4 commits Sep 13, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 16, 2019

Codecov Report

Merging #741 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #741   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files         118      118           
  Lines       10352    10352           
=======================================
  Hits        10111    10111           
  Misses        241      241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b7a2e6...1c8bb07. Read the comment docs.

@kmax12
kmax12 approved these changes Sep 16, 2019
@rwedge rwedge merged commit 61474fd into master Sep 16, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 8b7a2e6...1c8bb07
Details
codecov/project 97.67% remains the same compared to 8b7a2e6
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the remove-pytest-runner branch Sep 16, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.