Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar undercounting #743

Merged
merged 5 commits into from Sep 18, 2019

Conversation

@kmax12
Copy link
Contributor

commented Sep 16, 2019

The current logic undercounts the progress. This PR fixes how we do the count.

Added a test case

kmax12 added 2 commits Sep 16, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 18, 2019

Codecov Report

Merging #743 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #743      +/-   ##
==========================================
+ Coverage   97.65%   97.65%   +<.01%     
==========================================
  Files         118      118              
  Lines       10356    10364       +8     
==========================================
+ Hits        10113    10121       +8     
  Misses        243      243
Impacted Files Coverage Δ
featuretools/tests/synthesis/test_dfs_method.py 100% <100%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 98.23% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.37% <100%> (ø) ⬆️
...s/computational_backends/feature_set_calculator.py 98.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67322e5...6680785. Read the comment docs.

@kmax12 kmax12 changed the title [WIP] Fix progress bar undercounting Fix progress bar undercounting Sep 18, 2019
@kmax12 kmax12 requested a review from angela97lin Sep 18, 2019
Copy link
Contributor

left a comment

LGTM! Glad you were able to track down the num_features undercounting!

@kmax12 kmax12 merged commit 2ff8d17 into master Sep 18, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.65%)
Details
codecov/project 97.65% (+<.01%) compared to 67322e5
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@kmax12 kmax12 deleted the fix-progress-bar-undercounting branch Sep 18, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.