Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing njobs to dask_kwargs for test cases w/ progress_callback #745

Merged
merged 2 commits into from Sep 16, 2019

Conversation

@angela97lin
Copy link
Contributor

commented Sep 16, 2019

changing njobs to dask_kwargs for test cases w/ progress_callback

@angela97lin angela97lin requested a review from rwedge Sep 16, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 16, 2019

Codecov Report

Merging #745 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #745      +/-   ##
==========================================
- Coverage   97.67%   97.65%   -0.02%     
==========================================
  Files         118      118              
  Lines       10352    10356       +4     
==========================================
+ Hits        10111    10113       +2     
- Misses        241      243       +2
Impacted Files Coverage Δ
featuretools/tests/synthesis/test_dfs_method.py 100% <100%> (ø) ⬆️
...utational_backend/test_calculate_feature_matrix.py 99.37% <100%> (ø) ⬆️
...computational_backends/calculate_feature_matrix.py 98.23% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61474fd...4648d6c. Read the comment docs.

@rwedge
rwedge approved these changes Sep 16, 2019
Copy link
Collaborator

left a comment

Looks good

@angela97lin angela97lin merged commit 9f81753 into master Sep 16, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.67%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +2.32% compared to 61474fd
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@angela97lin angela97lin deleted the progress_callback_fix branch Sep 16, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.